[v25.3.x] [CORE-15247] kafka: add size validation to string & arrays read off the wire#29227
Merged
michael-redpanda merged 3 commits intoredpanda-data:v25.3.xfrom Jan 12, 2026
Conversation
For string, array, and number of tags. (cherry picked from commit 13d3f76)
(cherry picked from commit 61bfa92)
Add wire_validation_test.cc with tests that verify bounds checking and error handling in the Kafka protocol decoder. Tests cover: - Array length validation (exceeds buffer, negative, max int32) - Flex array validation (exceeds buffer, zero length) - String/flex string validation (exceeds buffer, negative/zero length) - Bytes/flex bytes validation - Tagged fields validation (count exceeds buffer, duplicate/non-ascending IDs, size exceeds buffer) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> (cherry picked from commit a78c238)
WillemKauf
approved these changes
Jan 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of PR #29208