compare_screenshot_threshold() should not error from screenshot_max_difference()#276
Merged
compare_screenshot_threshold() should not error from screenshot_max_difference()#276
compare_screenshot_threshold() should not error from screenshot_max_difference()#276Conversation
Collaborator
Author
|
Failure is unrelated to PR. Merging |
schloerke
added a commit
that referenced
this pull request
Feb 22, 2023
* main:
Update cran-comments.md
Update cran-comments.md
Run revdep
Move crashpad file to setup test file
Update cran-comments.md
Remove detritus Crashpad file/directory on CRAN
Don't use github `{lintr}` or `{decor}` package
Run revdep on 12 pkgs; ✅
Remove C++11 from DESCRIPTION (#326)
News entries for #284 and #288
Load global vars when saving app objects (#307)
Better error message when both app.R and server.R are found (#284)
Don't assume preview overflow is of length 1 (#291)
Force JS code to be a character for `{glue}` support (#288)
fix typo: expect_unqiue_names -> expect_unique... (#270)
Fix typo: use_shinytest -> use_shinytest2 (#269)
`compare_screenshot_threshold()` should not error from `screenshot_max_difference()` (#276)
Increment version number to 0.2.1
Change default screenshot selector to `"scrollable_area"` (from bounding box of `"html"` DOM) (#325)
actions/test-app; Add multi app `app-dir` support; Default upload-snapshot to `true` (#322)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If
screenshot_max_difference()throws and error,compare_screenshot_threshold()should returnFALSE(to signify the images are different).