Skip to content

actions/test-app; Add multi app app-dir support; Default upload-snapshot to true#322

Merged
schloerke merged 27 commits intomainfrom
cpsievert-patch-1
Feb 10, 2023
Merged

actions/test-app; Add multi app app-dir support; Default upload-snapshot to true#322
schloerke merged 27 commits intomainfrom
cpsievert-patch-1

Conversation

@cpsievert
Copy link
Copy Markdown
Contributor

@cpsievert cpsievert commented Feb 5, 2023

@cpsievert
Copy link
Copy Markdown
Contributor Author

cpsievert commented Feb 6, 2023

In the spirit of "less boilerplate", would it make sense for app-dir to support multiple paths? So this that this

https://rstudio.github.io/shinytest2/articles/use-ci.html#check-app-yaml-1

becomes

- uses: rstudio/shinytest2/actions/test-app@v1
        with:
          app-dir: 
            - "01_hello"
            - "06_tabsets"

@schloerke
Copy link
Copy Markdown
Collaborator

Multi app support is now like

      - uses: rstudio/shinytest2/actions/test-app@v1
        with:
          app-dir: |
            01_hello
            06_tabsets

@schloerke schloerke changed the title Fix/add check-app.yaml actions/test-app; Add multi app app-dir support; Default upload-snapshot to true Feb 10, 2023
@schloerke schloerke merged commit 8702cd5 into main Feb 10, 2023
@schloerke schloerke deleted the cpsievert-patch-1 branch February 10, 2023 18:07
schloerke added a commit that referenced this pull request Feb 10, 2023
* main:
  actions/test-app; Add multi app `app-dir` support; Default upload-snapshot to `true`  (#322)
schloerke added a commit that referenced this pull request Feb 22, 2023
* main:
  Update cran-comments.md
  Update cran-comments.md
  Run revdep
  Move crashpad file to setup test file
  Update cran-comments.md
  Remove detritus Crashpad file/directory on CRAN
  Don't use github `{lintr}` or `{decor}` package
  Run revdep on 12 pkgs; ✅
  Remove C++11 from DESCRIPTION (#326)
  News entries for #284 and #288
  Load global vars when saving app objects (#307)
  Better error message when both app.R and server.R are found (#284)
  Don't assume preview overflow is of length 1 (#291)
  Force JS code to be a character for `{glue}` support (#288)
  fix typo: expect_unqiue_names -> expect_unique... (#270)
  Fix typo: use_shinytest -> use_shinytest2 (#269)
  `compare_screenshot_threshold()` should not error from `screenshot_max_difference()` (#276)
  Increment version number to 0.2.1
  Change default screenshot selector to `"scrollable_area"` (from bounding box of `"html"` DOM) (#325)
  actions/test-app; Add multi app `app-dir` support; Default upload-snapshot to `true`  (#322)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

test-app action's app-dir parameter doesn't work well with renv

2 participants