Allow trailing `self` in more contexts by mu001999 · Pull Request #155137 · rust-lang/rust

mu001999 · 2026-04-11T03:13:45Z

Reference PR:

Document trailing self in paths reference#2237

View all comments

As a follow-up PR to #152996, after this PR:

Trailing self can appear in paths
E0429 will be no longer emitted, use ...::self [as target]; will be equivalent to use ...::{self [as target]};

r? petrochenkov

mu001999 · 2026-04-13T13:38:55Z

@rustbot review

petrochenkov · 2026-04-13T14:07:47Z

@mu001999 could you write a change description for lang team for this PR, like in the previous PRs?
I'll nominate it once it's written and the other comments are addressed.
@rustbot author

rustbot · 2026-04-13T14:07:52Z

Reminder, once the PR becomes ready for a review, use @rustbot ready.

mu001999 · 2026-04-13T15:46:15Z

Description for lang team

This PR implements the last part of the lang team guidance from #146972 (comment).
It relaxes the rules to allow trailing self in more context.

Concretely, after this PR

use foo::self [as bar]; would be accepted and is resolved the same way as use foo::{self [as bar]};, instead of being rejected with E0429.
In non-import paths, trailing self would be accepted as well. This will make things like type E = path::to::Enum::self; and pub(in path::to::Mod::self) accepted.

And technically, this PR will not break existing code.

mu001999 · 2026-04-13T15:47:21Z

@rustbot review

traviscross · 2026-04-15T15:45:54Z

Makes sense to me. Thanks @mu001999 for pushing this along. Let's propose to do it.

@rfcbot fcp merge lang

rust-rfcbot · 2026-04-15T15:45:57Z

Team member @traviscross has proposed to merge this. The next step is review by the rest of the tagged team members:

No concerns currently listed.

Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

cc @rust-lang/lang-advisors: FCP proposed for lang, please feel free to register concerns.
See this document for info about what commands tagged team members can give me.

tmandry · 2026-04-15T15:46:12Z

@rfcbot reviewed

rust-rfcbot · 2026-04-25T15:48:08Z

The final comment period, with a disposition to merge, as per the review above, is now complete.

As the automated representative of the governance process, I would like to thank the author for their work and everyone else who contributed.

rustbot · 2026-04-27T02:59:58Z

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

petrochenkov · 2026-04-27T15:25:23Z

@bors r+

rust-bors · 2026-04-27T15:25:27Z

📌 Commit d93395c has been approved by petrochenkov

It is now in the queue for this repository.

…trochenkov Allow trailing `self` in more contexts Reference PR: - rust-lang/reference#2237 As a follow-up PR to rust-lang#152996, after this PR: 1. Trailing `self` can appear in paths 2. [E0429](https://doc.rust-lang.org/stable/error_codes/E0429.html#error-code-e0429) will be no longer emitted, `use ...::self [as target];` will be equivalent to `use ...::{self [as target]};` r? petrochenkov

…uwer Rollup of 9 pull requests Successful merges: - #155760 (Remove `AttributeLintKind`) - #154510 (Partially stabilize LoongArch target features) - #155137 (Allow trailing `self` in more contexts) - #155433 (Rip out rustc_layout_scalar_valid_range_* attribute support) - #155702 (Change `ItemKind::Trait` to a field variant.) - #154896 (Fix ICE: Scalar layout for non-primitive non-enum type unsafe binder) - #155675 (Disallow non_exhaustive structs and enums with non_exhaustive variants from implementing `ConstParamTy`) - #155874 (Avoid misleading closure return type note) - #155876 (CI: rfl: move job forward to Linux v7.1-rc1)

…uwer Rollup of 8 pull requests Successful merges: - #154510 (Partially stabilize LoongArch target features) - #155137 (Allow trailing `self` in more contexts) - #155513 (rustc_public: implement `Pattern` type) - #155702 (Change `ItemKind::Trait` to a field variant.) - #154896 (Fix ICE: Scalar layout for non-primitive non-enum type unsafe binder) - #155675 (Disallow non_exhaustive structs and enums with non_exhaustive variants from implementing `ConstParamTy`) - #155874 (Avoid misleading closure return type note) - #155876 (CI: rfl: move job forward to Linux v7.1-rc1)

Rollup merge of #155137 - mu001999-contrib:self-at-end, r=petrochenkov Allow trailing `self` in more contexts Reference PR: - rust-lang/reference#2237 As a follow-up PR to #152996, after this PR: 1. Trailing `self` can appear in paths 2. [E0429](https://doc.rust-lang.org/stable/error_codes/E0429.html#error-code-e0429) will be no longer emitted, `use ...::self [as target];` will be equivalent to `use ...::{self [as target]};` r? petrochenkov

rustbot assigned petrochenkov Apr 11, 2026

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Apr 11, 2026

petrochenkov reviewed Apr 13, 2026

View reviewed changes

Comment thread compiler/rustc_resolve/src/build_reduced_graph.rs

Comment thread compiler/rustc_resolve/src/ident.rs Outdated

petrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 13, 2026

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Apr 13, 2026

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 13, 2026

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Apr 13, 2026

petrochenkov added S-waiting-on-t-lang Status: Awaiting decision from T-lang I-lang-nominated Nominated for discussion during a lang team meeting. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 14, 2026

traviscross added P-lang-drag-1 Lang team prioritization drag level 1. https://rust-lang.zulipchat.com/#narrow/channel/410516-t-lang T-lang Relevant to the language team labels Apr 15, 2026

rust-rfcbot added proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. labels Apr 15, 2026

This comment has been minimized.

Sign in to view

rustbot mentioned this pull request Apr 25, 2026

Tracking issue for release notes of #155137: Allow trailing self in more contexts #155782

Open

mu001999 added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-t-lang Status: Awaiting decision from T-lang labels Apr 26, 2026

Support trailing self in import paths

d5a26d8

mu001999 force-pushed the self-at-end branch from cf86ae1 to d46d45c Compare April 27, 2026 02:59

This comment has been minimized.

Sign in to view

mu001999 added 4 commits April 27, 2026 14:02

Support trailing self in normal paths

4467940

Remove type_ns_only

8b584eb

Add test for middle self

ddb2721

Remove the special case of ::self after edition 2018

d93395c

mu001999 force-pushed the self-at-end branch from d46d45c to d93395c Compare April 27, 2026 06:02

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 27, 2026

JonathanBrouwer mentioned this pull request Apr 27, 2026

Rollup of 9 pull requests #155885

Closed

JonathanBrouwer mentioned this pull request Apr 27, 2026

Rollup of 8 pull requests #155890

Merged

rust-bors Bot merged commit 56c2ab6 into rust-lang:main Apr 28, 2026
11 checks passed

rustbot added this to the 1.97.0 milestone Apr 28, 2026

mu001999 deleted the self-at-end branch April 28, 2026 06:21

Uh oh!

Conversation

mu001999 commented Apr 11, 2026 • edited by traviscross Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mu001999 commented Apr 13, 2026

Uh oh!

petrochenkov commented Apr 13, 2026

Uh oh!

rustbot commented Apr 13, 2026

Uh oh!

mu001999 commented Apr 13, 2026

Description for lang team

Uh oh!

mu001999 commented Apr 13, 2026

Uh oh!

traviscross commented Apr 15, 2026

Uh oh!

rust-rfcbot commented Apr 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tmandry commented Apr 15, 2026

Uh oh!

This comment has been minimized.

rust-rfcbot commented Apr 25, 2026

Uh oh!

rustbot commented Apr 27, 2026

Uh oh!

This comment has been minimized.

petrochenkov commented Apr 27, 2026

Uh oh!

rust-bors Bot commented Apr 27, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

mu001999 commented Apr 11, 2026 •

edited by traviscross

Loading

rust-rfcbot commented Apr 15, 2026 •

edited

Loading