Change ItemKind::Trait to a field variant.#155702
Merged
rust-bors[bot] merged 1 commit intorust-lang:mainfrom Apr 28, 2026
Merged
Change ItemKind::Trait to a field variant.#155702rust-bors[bot] merged 1 commit intorust-lang:mainfrom
ItemKind::Trait to a field variant.#155702rust-bors[bot] merged 1 commit intorust-lang:mainfrom
Conversation
Collaborator
|
Some changes occurred in src/tools/clippy cc @rust-lang/clippy Some changes occurred in compiler/rustc_passes/src/check_attr.rs |
rustbot
added
A-attributes
Collaborator
|
rustbot has assigned @petrochenkov. Use Why was this reviewer chosen?The reviewer was selected based on:
|
Contributor
Typically |
petrochenkov
added
S-waiting-on-author
mejrs
force-pushed
the
itemkind_trait-fields
branch
from
e4824a5 to
9515f52
Compare
mejrs
added
S-waiting-on-review
Contributor
|
@bors r+ |
Contributor
rust-bors
Bot
added
S-waiting-on-bors
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Apr 27, 2026
…rochenkov Change `ItemKind::Trait` to a field variant. This changes `ItemKind::Trait` from an octuple(!!) to an enum variant with fields. Their names were chosen to match up with existing usage and minimize renaming. I'm leaning towards renaming `ident` to `name` as well; let me know if that's desired.
rust-bors Bot
pushed a commit
that referenced
this pull request
Apr 27, 2026
…uwer Rollup of 9 pull requests Successful merges: - #155760 (Remove `AttributeLintKind`) - #154510 (Partially stabilize LoongArch target features) - #155137 (Allow trailing `self` in more contexts) - #155433 (Rip out rustc_layout_scalar_valid_range_* attribute support) - #155702 (Change `ItemKind::Trait` to a field variant.) - #154896 (Fix ICE: Scalar layout for non-primitive non-enum type unsafe binder) - #155675 (Disallow non_exhaustive structs and enums with non_exhaustive variants from implementing `ConstParamTy`) - #155874 (Avoid misleading closure return type note) - #155876 (CI: rfl: move job forward to Linux v7.1-rc1)
rust-bors Bot
pushed a commit
that referenced
this pull request
Apr 27, 2026
…uwer Rollup of 8 pull requests Successful merges: - #154510 (Partially stabilize LoongArch target features) - #155137 (Allow trailing `self` in more contexts) - #155513 (rustc_public: implement `Pattern` type) - #155702 (Change `ItemKind::Trait` to a field variant.) - #154896 (Fix ICE: Scalar layout for non-primitive non-enum type unsafe binder) - #155675 (Disallow non_exhaustive structs and enums with non_exhaustive variants from implementing `ConstParamTy`) - #155874 (Avoid misleading closure return type note) - #155876 (CI: rfl: move job forward to Linux v7.1-rc1)
rust-timer
added a commit
that referenced
this pull request
Apr 28, 2026
Rollup merge of #155702 - mejrs:itemkind_trait-fields, r=petrochenkov Change `ItemKind::Trait` to a field variant. This changes `ItemKind::Trait` from an octuple(!!) to an enum variant with fields. Their names were chosen to match up with existing usage and minimize renaming. I'm leaning towards renaming `ident` to `name` as well; let me know if that's desired.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changes
ItemKind::Traitfrom an octuple(!!) to an enum variant with fields. Their names were chosen to match up with existing usage and minimize renaming.I'm leaning towards renaming
identtonameas well; let me know if that's desired.