Add basic dmaker.fan.p11 support#850
Merged
syssi merged 2 commits intorytilahti:masterfrom Nov 5, 2020
Merged
Conversation
Contributor
|
I own this fan model (dmaker.fan.p11), and it seems that 'status' siid:2, piid:6 is actually fan speed of level 1~100 Therefore, line #50 of fan_miot.py should be I have made a pull request of this fix. |
Collaborator
Author
|
@iquix Thanks for you support! I will fix the issue right away. |
Collaborator
Author
|
@iquix Could you provide the model no. your of device? I want to use it here soon: https://github.com/syssi/xiaomi_airpurifier#supported-devices |
Contributor
|
The brand is mijia and the model no. is BPLDS03DM. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm trying to get this fan supported in 0.5.4 already.