Conversation
…am docs (#512, #513) Bug fixes: - Chart create-from-range: wrap sheet name in single quotes for COM source data reference - PivotTable create-from-range: same quoting fix for pivot cache source data - Worksheet rename: update target_name XML doc to mention rename action Regression tests (12 new): - 4 chart tests (sheet names with spaces, data at non-first row) - 3 pivot table tests (source/dest sheet with spaces, hyphen in name) - 5 MCP server worksheet rename parameter contract tests Closes #512, closes #513
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
sbroenne
deleted the
fix/512-513-sheet-name-quoting-and-rename-params
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes two bugs reported in the Excel MCP bug report (2026-02-23):
Bug 1 & 3: Sheet name quoting in COM source data references (#512)
Root cause: ChartCommands.Lifecycle.cs and PivotTableCommands.Create.cs construct source data references as $"{sourceSheet}!{sourceRange}" without quoting the sheet name. Excel COM requires single quotes for sheet names with spaces or special characters: 'Sheet Name'!A1:D6.
Fix: Wrap sheet names in single quotes (safe for all names, even without spaces).
Files changed:
Bug 2: Worksheet rename parameter discoverability (#513)
Root cause: \ExcelWorksheetTool.cs\ is manually written (not source-generated) and the \ arget_name\ parameter description only mentioned "copied" worksheet, not "renamed".
Fix: Updated XML doc to: "New name for the worksheet (required for: rename, copy)"
File changed:
Regression Tests (12 new)
All 12 tests pass. Pre-commit hooks pass (COM leak check, coverage audit, CLI workflow, MCP smoke test).
Closes #512, closes #513