[router][grpc] Fix tool call id in parse_json_schema_response

[CatherineSue]

Motivation

This PR fixes the incorrect ToolCall.id format in parse_json_schema_response. It should match the same behavior as parse_tool_calls.

Modifications

• Add model and history_tool_calls_count params to parse_json_schema_response
• Fixed tool call id generation to use generate_tool_call_id

Accuracy Tests

Benchmarking and Profiling

Checklist

• Format your code according to the Format code with pre-commit.
• Add unit tests according to the Run and add unit tests.
• Update documentation according to Write documentations.
• Provide accuracy and speed benchmark results according to Test the accuracy and Benchmark the speed.

[gemini-code-assist]

Summary of Changes

Hello @CatherineSue, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves an issue in the sgl-router's gRPC utility, specifically within the parse_json_schema_response function. The change addresses an incorrect formatting of the ToolCall.id, ensuring that these identifiers are generated with the intended structure. This enhancement improves the robustness and correctness of tool call handling within the system.

Highlights

• Tool Call ID Fix: Corrected the format of ToolCall.id within the parse_json_schema_response function to ensure proper identification of tool calls.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[CatherineSue]

/gemini review

[gemini-code-assist]

Code Review

This pull request correctly addresses an inconsistency in ToolCall.id generation within parse_json_schema_response. By introducing model and history_tool_calls_count parameters and leveraging the existing generate_tool_call_id utility function, the changes ensure that tool call IDs are formatted consistently with other parts of the system, particularly parse_tool_calls. This change correctly handles different ID formats required by models like KimiK2 and the standard OpenAI format. The implementation is clean, well-focused, and improves the robustness and consistency of tool call handling. The changes look good and I don't see any issues.