Conversation
hnyls2002
commented
Nov 8, 2025
Summary of ChangesHello @hnyls2002, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request makes a minor but important adjustment to the continuous integration pipeline by updating the estimated run times for two key test files. This change is intended to ensure that the CI system allocates sufficient resources and time for these tests to complete successfully, thereby improving the reliability and efficiency of the overall build process. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request adjusts the estimated CI execution times for test_eagle_infer_a.py and test_eagle_infer_b.py, increasing them significantly. This is presumably to fix CI timeouts. The change is straightforward, but for future maintainability, I've suggested adding a comment to explain the reason for this large adjustment. Also, note the typo in the PR title ('esitmation').
| TestFile("test_eagle_infer_a.py", 750), | ||
| TestFile("test_eagle_infer_b.py", 750), |
There was a problem hiding this comment.
For better maintainability, it would be helpful to add a comment explaining why these timeout values were increased so significantly. This context will be valuable for anyone looking at these values in the future.
For example:
# Increased from 370/500 to 750 to fix CI timeouts on <date>. See PR #... for details.