Skip to content

Conversation

@hnyls2002
Copy link
Collaborator

image

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @hnyls2002, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request makes a minor but important adjustment to the continuous integration pipeline by updating the estimated run times for two key test files. This change is intended to ensure that the CI system allocates sufficient resources and time for these tests to complete successfully, thereby improving the reliability and efficiency of the overall build process.

Highlights

  • CI Estimation Time Adjustment: The estimated execution times for two specific test files, test_eagle_infer_a.py and test_eagle_infer_b.py, have been updated within the CI suite configuration.
  • Increased Time Allocation: The estimated time for test_eagle_infer_a.py was increased from 370 to 750, and for test_eagle_infer_b.py from 500 to 750, likely to prevent timeouts or improve CI scheduling accuracy.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@hnyls2002 hnyls2002 merged commit 6fee2c5 into main Nov 8, 2025
4 of 15 checks passed
@hnyls2002 hnyls2002 deleted the lsyin/tiny-adjust-ci-time branch November 8, 2025 15:02
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adjusts the estimated CI execution times for test_eagle_infer_a.py and test_eagle_infer_b.py, increasing them significantly. This is presumably to fix CI timeouts. The change is straightforward, but for future maintainability, I've suggested adding a comment to explain the reason for this large adjustment. Also, note the typo in the PR title ('esitmation').

Comment on lines +73 to +74
TestFile("test_eagle_infer_a.py", 750),
TestFile("test_eagle_infer_b.py", 750),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For better maintainability, it would be helpful to add a comment explaining why these timeout values were increased so significantly. This context will be valuable for anyone looking at these values in the future.

For example:

# Increased from 370/500 to 750 to fix CI timeouts on <date>. See PR #... for details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants