Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions test/srt/run_suite.py
Original file line number Diff line number Diff line change
Expand Up @@ -70,8 +70,8 @@ class TestFile:
TestFile("test_chunked_prefill.py", 410),
TestFile("test_create_kvindices.py", 2),
TestFile("test_deterministic.py", 320),
TestFile("test_eagle_infer_a.py", 370),
TestFile("test_eagle_infer_b.py", 500),
TestFile("test_eagle_infer_a.py", 750),
TestFile("test_eagle_infer_b.py", 750),
Comment on lines +73 to +74
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For better maintainability, it would be helpful to add a comment explaining why these timeout values were increased so significantly. This context will be valuable for anyone looking at these values in the future.

For example:

# Increased from 370/500 to 750 to fix CI timeouts on <date>. See PR #... for details.

TestFile("test_eagle_infer_beta.py", 90),
TestFile("test_constrained_decoding.py", 120),
TestFile("test_eval_fp8_accuracy.py", 303),
Expand Down
Loading