Gloas get payload envelope beacon API#9038
Conversation
eserilev
changed the title
dknopik
left a comment
dknopik
left a comment
There was a problem hiding this comment.
This is missing ethereum/beacon-APIs#588 - which looks like it might be relevant.
I weighted in on the open question in there, did not see this PR before, sorry!
| if let Some(event_handler) = chain.event_handler.as_ref() | ||
| && event_handler.has_execution_payload_bid_subscribers() | ||
| && let Ok(bid) = block.message().body().signed_execution_payload_bid() | ||
| { | ||
| event_handler.register(EventKind::ExecutionPayloadBid(Box::new(bid.clone()))); | ||
| } |
There was a problem hiding this comment.
I think the intention of the bid metric is more that it should be emitted when a valid bid is received from gossip or the API. Both of course are not implemented yet - so I do not think we can implement this metric now
|
@dknopik i think ill leave the ethereum/beacon-APIs#588 stuff to a separate PR as its not required for dora functionality. this PR was just extracting stuff that was originally in the |
|
@dknopik sorry it was late at night for me when I first responded to your comments and I think I misread. I'm going to leave out the SSE stuff in this PR and just include the 'GET' payload envelope beacon api change. If you want to implement the SSE changes please feel free! |
eserilev
changed the title
chong-he
left a comment
chong-he
left a comment
There was a problem hiding this comment.
Looks good to me.
There is no test yet for this endpoint as highlighted in TODO which can be added later.
macladson
added
ready-for-merge
Merge Queue Status
This pull request spent 30 minutes 50 seconds in the queue, including 28 minutes 45 seconds running CI. Required conditions to merge
|
4 participants
And a new beacon api endpoint
/eth/v1/beacon/execution_payload_envelope/{block_id}
This is required for dora to work properly for ePBS