Emit SSE: execution_payload#9065
Merged
Merged
Conversation
Co-Authored-By: Eitan Seri-Levi <eserilev@gmail.com>
|
Some required checks have failed. Could you please take a look @dknopik? 🙏 |
mergify
Bot
added
waiting-on-author
mergify
Bot
added
ready-for-review
jimmygchen
approved these changes
Apr 1, 2026
Member
jimmygchen
left a comment
jimmygchen
left a comment
There was a problem hiding this comment.
Looks good!
This pending spec PR says this event is emitted after the payload is successfully imported into fork choice (https://github.com/ethereum/beacon-APIs/pull/588/changes#diff-3cc6eaa800c1a4bd6adcd78f1722b466f7a24048a66e320c8f92872fbcd9eefbR161). We don't have fork choice changes yet, but this is correctly positioned after where the fork choice logic will go.
We don't have test cover for this, unfortunately this requires test harness to support Gloas (@michaelsproul is working on this)
jimmygchen
added
ready-for-merge
Merge Queue Status
This pull request spent 42 minutes 55 seconds in the queue, including 25 minutes 43 seconds running CI. Required conditions to merge
|
10 tasks
This was referenced Apr 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Emit
execution_payloadon successful import of an execution payload.Additional information
Builds upon #9053.
Eitan's PR #9038 previously emitted
execution_payload_availablehere, but ethereum/beacon-APIs#588 specifies thatexecution_payloadis to be emitted on import - matching theblockevent nomenclature. A PR forexecution_payload_availablewill follow.