fix gen1 stadium confusion to announce move name before self-hit#11770
Open
TurboRx wants to merge 1 commit intosmogon:masterfrom
Open
fix gen1 stadium confusion to announce move name before self-hit#11770TurboRx wants to merge 1 commit intosmogon:masterfrom
TurboRx wants to merge 1 commit intosmogon:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: https://www.smogon.com/forums/threads/gen-1-stadium-mechanics.3777745/
confusion self-hit in gen1 stadium now shows the move name before the damage message, matching cartridge behavior. previously the move was aborted before announcement because confusion used
onBeforeMovewhich runs before the "pokemon used move" message. fixed by splitting the logic:onBeforeMovehandles activation and timer,onTryMovehandles self-hit check and damage. this follows the same architectural pattern as primordial sea and desolate land - moves that need to show the name before blocking useonTryMoveinstead ofonBeforeMove. standard rby behavior unchanged since it doesn't inherit this change.