Fix broadcast intended move before confusion self-hit in gen1 stadium#11773
Closed
TurboRx wants to merge 1 commit intosmogon:masterfrom
Closed
Fix broadcast intended move before confusion self-hit in gen1 stadium#11773TurboRx wants to merge 1 commit intosmogon:masterfrom
TurboRx wants to merge 1 commit intosmogon:masterfrom
Conversation
Collaborator
|
You already have one PR that creates a |
Contributor
Author
|
sorry my bad thx for pointing it, I was working on multiple PRs so made it by mistake. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: https://www.smogon.com/forums/threads/gen-1-stadium-mechanics.3777745/
currently in gen1stadium, the sim skips showing the intended move when a confused pokemon hits itself, stadium actually does show it before the self-hit animation. fixed by overriding
onBeforeMovefor confusion in gen1stadium conditions to calladdMovebefore dealing the self-hit damage, same pattern as choicelock. added a test that verifies the move appears in the log before the confusion damage.