Skip to content

Modify driver api list_*_groups() to return relations#793

Merged
skdwriting merged 2 commits intosodafoundation:masterfrom
joseph-v:host-mapping-rel
Jan 10, 2022
Merged

Modify driver api list_*_groups() to return relations#793
skdwriting merged 2 commits intosodafoundation:masterfrom
joseph-v:host-mapping-rel

Conversation

@joseph-v
Copy link
Collaborator

@joseph-v joseph-v commented Jan 6, 2022

What this PR does / why we need it:
This PR change Hostmapping

  1. Modify driver API list_<*>_groups() to add relations also in the return value
  2. Remove port_id from the MaskingViews model

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

Release note:

@joseph-v joseph-v force-pushed the host-mapping-rel branch 6 times, most recently from f2bf6f8 to 1debc80 Compare January 7, 2022 04:31
@codecov
Copy link

codecov bot commented Jan 7, 2022

Codecov Report

Merging #793 (fedc39b) into master (8c7b697) will decrease coverage by 0.02%.
The diff coverage is 91.66%.

@@            Coverage Diff             @@
##           master     #793      +/-   ##
==========================================
- Coverage   70.58%   70.56%   -0.03%     
==========================================
  Files         180      180              
  Lines       18641    18638       -3     
  Branches     2749     2749              
==========================================
- Hits        13158    13151       -7     
- Misses       4643     4645       +2     
- Partials      840      842       +2     
Impacted Files Coverage Δ
delfin/api/v1/masking_views.py 57.14% <ø> (ø)
delfin/db/sqlalchemy/models.py 99.66% <ø> (-0.01%) ⬇️
delfin/drivers/driver.py 61.76% <ø> (ø)
delfin/drivers/fake_storage/__init__.py 94.40% <87.87%> (-0.67%) ⬇️
delfin/task_manager/tasks/resources.py 85.84% <100.00%> (-0.90%) ⬇️

@joseph-v joseph-v changed the title [WIP] Modify list storage_host_groups to add rels Modify list storage_host_groups to add rels Jan 7, 2022
@joseph-v joseph-v changed the title Modify list storage_host_groups to add rels DO NOT MERGE: Modify list storage_host_groups to add rels Jan 7, 2022
@joseph-v joseph-v changed the title DO NOT MERGE: Modify list storage_host_groups to add rels DO NOT MERGE: Modify driver api list_*_groups() to return relations Jan 7, 2022
@joseph-v joseph-v changed the title DO NOT MERGE: Modify driver api list_*_groups() to return relations Modify driver api list_*_groups() to return relations Jan 10, 2022
Copy link
Collaborator

@wisererik wisererik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@skdwriting skdwriting left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments