Skip to content

Add log info when service stop failed.#907

Merged
joseph-v merged 1 commit intosodafoundation:masterfrom
JiuyunZhao:jiuyunzhao_add_log_20220630
Jun 14, 2022
Merged

Add log info when service stop failed.#907
joseph-v merged 1 commit intosodafoundation:masterfrom
JiuyunZhao:jiuyunzhao_add_log_20220630

Conversation

@JiuyunZhao
Copy link
Contributor

What this PR does / why we need it:
Add log info when service stop failed.
Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

Release note:

@codecov
Copy link

codecov bot commented Jun 13, 2022

Codecov Report

Merging #907 (0a0a5b7) into master (61fedb2) will decrease coverage by 0.00%.
The diff coverage is 12.50%.

@@            Coverage Diff             @@
##           master     #907      +/-   ##
==========================================
- Coverage   71.26%   71.26%   -0.01%     
==========================================
  Files         182      182              
  Lines       21326    21327       +1     
  Branches     3263     3264       +1     
==========================================
  Hits        15199    15199              
- Misses       5095     5096       +1     
  Partials     1032     1032              
Impacted Files Coverage Δ
delfin/service.py 26.72% <12.50%> (-0.11%) ⬇️

Copy link
Collaborator

@wisererik wisererik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@joseph-v joseph-v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joseph-v joseph-v merged commit 2fba071 into sodafoundation:master Jun 14, 2022
@JiuyunZhao JiuyunZhao deleted the jiuyunzhao_add_log_20220630 branch June 8, 2023 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments