Skip to content

Add log info when service stop failed. #907

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
joseph-v merged 1 commit into from
Jun 14, 2022
Merged

Add log info when service stop failed. #907

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 8 additions & 7 deletions delfin/service.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,18 +187,19 @@ def kill(self):
"""Destroy the service object in the datastore."""
self.stop()

def stop(self):
def stop(self, graceful=False):
# Try to shut the connection down, but if we get any sort of
# errors, go ahead and ignore them.. as we're shutting down anyway
try:
self.rpcserver.stop()
except Exception:
pass
if hasattr(self, 'rpcserver'):
self.rpcserver.stop()
except Exception as e:
LOG.error('Stop the rpc server failed, the reason is %s.', e)
for x in self.timers:
try:
x.stop()
except Exception:
pass
except Exception as e:
LOG.error('Stop the timers failed, the reason is %s.', e)
if self.coordinator:
try:
coordination.LOCK_COORDINATOR.stop()
Expand All @@ -208,7 +209,7 @@ def stop(self):

self.timers = []

super(Service, self).stop()
super(Service, self).stop(graceful)

def wait(self):
for x in self.timers:
Expand Down