Skip to content

PR: Fix several issues with the Outline#16111

Merged
ccordoba12 merged 12 commits intospyder-ide:5.xfrom
ccordoba12:fix-outline-issues
Aug 1, 2021
Merged

PR: Fix several issues with the Outline#16111
ccordoba12 merged 12 commits intospyder-ide:5.xfrom
ccordoba12:fix-outline-issues

Conversation

@ccordoba12
Copy link
Copy Markdown
Member

@ccordoba12 ccordoba12 commented Aug 1, 2021

Description of Changes

  • Symbols were not shown for files in projects when an __init__.py file is present at the root of the project.
  • Symbols were not updated when switching projects.
  • Don't send requests to the LSP server before it's been initialized (this was not compliant with the LSP protocol).
  • Remove from sys.path entries that come from our config system when passed to the LSP server and transport layer, and Spyder is running in dev or testing modes. That allows us to better test things in those modes.
  • Depends on Fix skipping imported symbols python-lsp/python-lsp-server#53

Issue(s) Resolved

Fixes #15648
Fixes #14871

Affirmation

By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.

I certify the above statement is true and correct: @ccordoba12

- This only applies in DEV mode or for tests.
- It's necessary to test the interaction between our PYTHONPATH manager
and the LSP as if Spyder is properly installed.
…rdoba12/python-lsp-server.git external-deps/python-lsp-server

subrepo:
  subdir:   "external-deps/python-lsp-server"
  merged:   "9f69edc24"
upstream:
  origin:   "https://github.com/ccordoba12/python-lsp-server.git"
  branch:   "fix-symbols"
  commit:   "9f69edc24"
git-subrepo:
  version:  "0.4.3"
  origin:   "https://github.com/ingydotnet/git-subrepo"
  commit:   "2f68596"
Getting symbols for project files in that case was failing before.
@ccordoba12 ccordoba12 added this to the v5.1.0 milestone Aug 1, 2021
@ccordoba12 ccordoba12 self-assigned this Aug 1, 2021
@ccordoba12 ccordoba12 changed the title PR: Fix several issues in the Outline PR: Fix several issues with the Outline Aug 1, 2021
@ccordoba12 ccordoba12 force-pushed the fix-outline-issues branch 3 times, most recently from ea724bd to 25e6396 Compare August 1, 2021 17:53
…lsp/python-lsp-server.git external-deps/python-lsp-server

subrepo:
  subdir:   "external-deps/python-lsp-server"
  merged:   "03ab6efde"
upstream:
  origin:   "https://github.com/python-lsp/python-lsp-server.git"
  branch:   "develop"
  commit:   "03ab6efde"
git-subrepo:
  version:  "0.4.3"
  origin:   "https://github.com/ingydotnet/git-subrepo"
  commit:   "2f68596"

[ci skip]
@ccordoba12 ccordoba12 merged commit eb3088a into spyder-ide:5.x Aug 1, 2021
@ccordoba12 ccordoba12 deleted the fix-outline-issues branch August 1, 2021 20:08
ccordoba12 added a commit that referenced this pull request Aug 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant