Skip to content

PR: Improve skipping imported symbols (Outline)#16255

Merged
ccordoba12 merged 7 commits intospyder-ide:5.xfrom
ccordoba12:skip-spurious-symbols-in-outline
Aug 21, 2021
Merged

PR: Improve skipping imported symbols (Outline)#16255
ccordoba12 merged 7 commits intospyder-ide:5.xfrom
ccordoba12:skip-spurious-symbols-in-outline

Conversation

@ccordoba12
Copy link
Copy Markdown
Member

@ccordoba12 ccordoba12 commented Aug 20, 2021 •
edited
Loading

Description of Changes

Affirmation

By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.

I certify the above statement is true and correct: @ccordoba12

@ccordoba12
Outline: Restore functionality to update all editors
cb34616 
This is necessary to update the outline for all files when closing a
project.
@ccordoba12
git subrepo clone --branch=improve-skip-symbols --force https://githu…
1543a7e 
…b.com/ccordoba12/python-lsp-server.git external-deps/python-lsp-server

subrepo:
  subdir:   "external-deps/python-lsp-server"
  merged:   "535d6e927"
upstream:
  origin:   "https://github.com/ccordoba12/python-lsp-server.git"
  branch:   "improve-skip-symbols"
  commit:   "535d6e927"
git-subrepo:
  version:  "0.4.3"
  origin:   "https://github.com/ingydotnet/git-subrepo"
  commit:   "2f68596"
@ccordoba12
Testing: Improve test_update_outline to catch other cases
b4a2ccb
@ccordoba12 ccordoba12 added this to the v5.1.2 milestone Aug 20, 2021
@ccordoba12 ccordoba12 self-assigned this Aug 20, 2021
@pep8speaks
Copy link
Copy Markdown

pep8speaks commented Aug 20, 2021 •
edited
Loading

Hello @ccordoba12! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 52:80: E501 line too long (80 > 79 characters)
Line 60:80: E501 line too long (90 > 79 characters)
Line 63:80: E501 line too long (83 > 79 characters)
Line 64:80: E501 line too long (85 > 79 characters)
Line 65:80: E501 line too long (83 > 79 characters)

Line 5:1: E302 expected 2 blank lines, found 1
Line 8:1: E302 expected 2 blank lines, found 1

Line 8:1: E302 expected 2 blank lines, found 1
Line 11:1: E302 expected 2 blank lines, found 1

Line 8:1: E302 expected 2 blank lines, found 1
Line 11:1: E302 expected 2 blank lines, found 1

Comment last updated at 2021-08-21 02:11:28 UTC

@ccordoba12 ccordoba12 mentioned this pull request Aug 21, 2021
Merged
@ccordoba12
git subrepo clone --branch=develop --force https://github.com/python-…
a5411c9 
…lsp/python-lsp-server.git external-deps/python-lsp-server

subrepo:
  subdir:   "external-deps/python-lsp-server"
  merged:   "b5b2ff027"
upstream:
  origin:   "https://github.com/python-lsp/python-lsp-server.git"
  branch:   "develop"
  commit:   "b5b2ff027"
git-subrepo:
  version:  "0.4.3"
  origin:   "https://github.com/ingydotnet/git-subrepo"
  commit:   "2f68596"

[ci skip]
@ccordoba12 ccordoba12 merged commit 5a4c2d3 into spyder-ide:5.x Aug 21, 2021
@ccordoba12 ccordoba12 deleted the skip-spurious-symbols-in-outline branch August 21, 2021 02:12
ccordoba12 added a commit that referenced this pull request Aug 21, 2021
@ccordoba12
Merge from 5.x: PR #16255
64b1b6f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@ccordoba12 ccordoba12

Labels

None yet

Projects

None yet

Milestone

v5.1.2

Development

Successfully merging this pull request may close these issues.

2 participants

@ccordoba12 @pep8speaks