Skip to content
This repository was archived by the owner on Jan 20, 2022. It is now read-only.

[PLEASE, REVIEW] feat(Icon): adding disabled prop to Icon#113

Closed
bmdalex wants to merge 1 commit intomasterfrom
feat/icon-disabled-prop
Closed

[PLEASE, REVIEW] feat(Icon): adding disabled prop to Icon#113
bmdalex wants to merge 1 commit intomasterfrom
feat/icon-disabled-prop

Conversation

@bmdalex
Copy link
Collaborator

@bmdalex bmdalex commented Jul 18, 2018

Icon (disabled prop)

This PR will introduce possibility to specify disabled icons

TODO

  • Conformance test
  • Minimal doc site example
  • Stardust base theme
  • Teams Light theme
  • Teams Dark theme
  • Teams Contrast theme
  • Confirm RTL usage
  • W3 accessibility check
  • Stardust accessibility check
  • Update glossary props table
  • Update the CHANGELOG.md

API Proposal

disabled

disabled property will disable icons by manipulating color and opacity CSS styles

screen shot 2018-07-18 at 20 54 06

<Icon disabled color="red" name="users" size="big" />

renders

<i class="ui-icon"></i>

@codecov
Copy link

codecov bot commented Jul 18, 2018

Codecov Report

Merging #113 into master will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #113      +/-   ##
==========================================
+ Coverage    69.8%   69.82%   +0.02%     
==========================================
  Files          75       75              
  Lines        1202     1203       +1     
  Branches      228      207      -21     
==========================================
+ Hits          839      840       +1     
  Misses        358      358              
  Partials        5        5
Impacted Files Coverage Δ
src/components/Icon/iconRules.ts 90.9% <100%> (+0.43%) ⬆️
src/components/Icon/Icon.tsx 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9b7f612...e2e8bad. Read the comment docs.

@kuzhelov kuzhelov changed the title feat(Icon): adding disabled prop to Icon [PLEASE, REVIEW] feat(Icon): adding disabled prop to Icon Jul 20, 2018
@bmdalex
Copy link
Collaborator Author

bmdalex commented Jul 25, 2018

Moved to new repo: stardust-ui/react/pull/12

@bmdalex bmdalex closed this Jul 25, 2018
@bmdalex bmdalex deleted the feat/icon-disabled-prop branch July 25, 2018 15:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant