This repository was archived by the owner on Jan 20, 2022. It is now read-only.
feat(Button): adding disabled prop to Button#114
Closed
Conversation
51a803b to
ef10c85
Compare
Codecov Report
@@ Coverage Diff @@
## master #114 +/- ##
==========================================
- Coverage 69.8% 69.77% -0.03%
==========================================
Files 75 76 +1
Lines 1202 1244 +42
Branches 228 221 -7
==========================================
+ Hits 839 868 +29
- Misses 358 371 +13
Partials 5 5
Continue to review full report at Codecov.
|
ef10c85 to
9a4fb9a
Compare
11 tasks
Collaborator
Author
|
Moved to new repo: stardust-ui/react/pull/14 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Button(
disabledprop)This PR will introduce possibility to specify
disabledbuttonsThis PR depends on the changes introduced in #111 so it contains these as well; #111 should be merge first and then this branch should be rebased
TODO
API Proposal
disabled
disabledproperty will disable buttons by manipulatingopacityCSS style, borders, colors, hover styles and preventing clickingKnow issue: Icons are not disabled because
disabledproperty was not added to icons at the time of creating this PR. I created a PR for that #113Icon buttons will become disabled out of the box after merging that one
will render