Skip to content
This repository was archived by the owner on Mar 4, 2020. It is now read-only.

fix(docs): Set maximum width for examples#1319

Merged
miroslavstastny merged 3 commits intomasterfrom
fix/docs-example-width
May 10, 2019
Merged

fix(docs): Set maximum width for examples#1319
miroslavstastny merged 3 commits intomasterfrom
fix/docs-example-width

Conversation

@miroslavstastny
Copy link
Member

Fixes #1317.

Before:
image

After:
image

The visible overflow is intentional.


const TextExampleTruncatedShorthand = () => (
<div style={{ overflow: 'hidden', textOverflow: 'ellipsis', width: 500 }}>
<div style={{ overflow: 'hidden', textOverflow: 'ellipsis' }}>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reverted suboptimal fix from #1019

@codecov
Copy link

codecov bot commented May 10, 2019

Codecov Report

Merging #1319 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1319   +/-   ##
=======================================
  Coverage   72.36%   72.36%           
=======================================
  Files         756      756           
  Lines        5678     5678           
  Branches     1662     1662           
=======================================
  Hits         4109     4109           
  Misses       1563     1563           
  Partials        6        6

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eb47a32...267c71f. Read the comment docs.

@miroslavstastny miroslavstastny merged commit 5e76653 into master May 10, 2019
@delete-merged-branch delete-merged-branch bot deleted the fix/docs-example-width branch May 10, 2019 12:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Docs: wide example breaks docsite layout

2 participants