This repository was archived by the owner on Mar 4, 2020. It is now read-only.
Conversation
…is already closed
Codecov Report
@@ Coverage Diff @@
## master #1373 +/- ##
==========================================
+ Coverage 72.92% 72.93% +0.01%
==========================================
Files 775 775
Lines 5824 5823 -1
Branches 1721 1698 -23
==========================================
Hits 4247 4247
+ Misses 1571 1570 -1
Partials 6 6
Continue to review full report at Codecov.
|
jurokapsiar
approved these changes
May 22, 2019
mnajdova
approved these changes
May 23, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If ESC key is pressed on a trigger button and Popup is closed, then this keyboard event should propagate to a parent element.
Use case, in chat pane prototype, in the message, when pressing ESC key on more options button of the attachment:
Expected:
Actual:
keyboard event is not propagated and focus does not go to the message container