This repository was archived by the owner on Mar 4, 2020. It is now read-only.
fix(Popup): Move trapFocus and autoFocus to props from accessibility behaviors#1565
Merged
fix(Popup): Move trapFocus and autoFocus to props from accessibility behaviors#1565
trapFocus and autoFocus to props from accessibility behaviors#1565Conversation
added 4 commits
July 1, 2019 15:21
Codecov Report
@@ Coverage Diff @@
## master #1565 +/- ##
==========================================
- Coverage 71.47% 71.28% -0.19%
==========================================
Files 848 846 -2
Lines 6938 6938
Branches 1983 2002 +19
==========================================
- Hits 4959 4946 -13
- Misses 1973 1986 +13
Partials 6 6
Continue to review full report at Codecov.
|
layershifter
reviewed
Jul 3, 2019
layershifter
reviewed
Jul 3, 2019
layershifter
reviewed
Jul 3, 2019
layershifter
reviewed
Jul 3, 2019
layershifter
reviewed
Jul 3, 2019
layershifter
reviewed
Jul 3, 2019
layershifter
reviewed
Jul 3, 2019
layershifter
reviewed
Jul 3, 2019
layershifter
approved these changes
Jul 8, 2019
trapFocus and autoFocus to props from accessibility behaviorstrapFocus and autoFocus to props from accessibility behaviors
trapFocus and autoFocus to props from accessibility behaviorstrapFocus and autoFocus to props from accessibility behaviors
This was referenced Jul 18, 2019
This was referenced Mar 11, 2020
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #1493
BREAKING CHANGES
popupFocusTrapBehavior.trapFocusprop added toPopup.popupAutoFocusBehavior.autoFocusprop added toPopup.Improvements
FocusTrapZoneandAutoFocusZoneare now integrated intoPopupContentwithout rendering an additionaldiv.trapFocuscan be set to popup usingtruevalue or an object ofFocusTrapZonePropsautoFocuscan be set to popup usingtruevalue or an object ofAutoFocusZonePropsinlineandtrapFocusprops. OrautoFocusfor non-inlinePopup.