fix: limit unsigned integer range. #1151#1216
Merged
mergify[bot] merged 4 commits intostoneatom:stonedb-5.7-devfrom Jan 13, 2023
Merged
Conversation
Contributor
|
Thanks for the contribution! Please review the labels and make any necessary changes. |
[summary] tinyint: signed range is -128 to 127, unsigned range is 0 to 127. smallint: signed range is -32768 to 32767, unsigned range is 0 to 32767. mediumint: signed range is -8388608 to 8388607, unsigned range is 0 to 8388607. int/integer: signed range is -2147483647 to 2147483647, unsigned range is 0 to 2147483647. Note: -2147483648 is not allowed in tianmu engine currently. bigint: signed range is -9223372036854775806 to 9223372036854775807, unsigned range is 0 to 9223372036854775807. Note: -9223372036854775807 will be set to null and -9223372036854775808 will ret out of range.
hustjieke
force-pushed
the
fix_limit_unsigned_integer_to_signed_boundary_issue1151
branch
from
3a61b96 to
d0efcbd
Compare
…file test unsigned, this will be opened after we completely support unsigned types stoneatom#1151
Collaborator
Author
|
Please make a CR @RingsC @wisehead @lujiashun @isredstar. |
wisehead
reviewed
Jan 13, 2023
wisehead
approved these changes
Jan 13, 2023
lujiashun
reviewed
Jan 13, 2023
hustjieke
force-pushed
the
fix_limit_unsigned_integer_to_signed_boundary_issue1151
branch
from
1f753c7 to
5dfe091
Compare
hustjieke
force-pushed
the
fix_limit_unsigned_integer_to_signed_boundary_issue1151
branch
from
5dfe091 to
7b94e51
Compare
Codecov ReportBase: 43.30% // Head: 43.34% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## stonedb-5.7-dev #1216 +/- ##
===================================================
+ Coverage 43.30% 43.34% +0.03%
===================================================
Files 1830 1830
Lines 396111 396130 +19
===================================================
+ Hits 171535 171698 +163
+ Misses 224576 224432 -144
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Collaborator
Author
|
PTAL @lujiashun |
…ned_boundary_issue1151
hustjieke
deleted the
fix_limit_unsigned_integer_to_signed_boundary_issue1151
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary about this PR
tinyint: signed range is -128 to 127, unsigned range is 0 to 127.
smallint: signed range is -32768 to 32767, unsigned range is 0 to 32767.
mediumint: signed range is -8388608 to 8388607, unsigned range is 0 to 8388607.
int/integer: signed range is -2147483647 to 2147483647, unsigned range is 0 to 2147483647. Note: -2147483648 is not allowed in tianmu engine currently.
bigint: signed range is -9223372036854775806 to 9223372036854775807, unsigned range is 0 to 9223372036854775807.
Note: -9223372036854775807 will be set to null and -9223372036854775808 will ret out of range.
Issue Number: close #1151
Tests Check List
Changelog
Documentation