Skip to content

fix: limit unsigned integer range. #1151 #1216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mergify merged 4 commits into from
Jan 13, 2023
Merged

fix: limit unsigned integer range. #1151 #1216

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d0efcbd
fix: limit unsigned integer range. #1151
hustjieke Jan 12, 2023
33f2561
fix: change auto_increment.testbak to backup test, the cases in this …
hustjieke Jan 12, 2023
7b94e51
fix: add TODO info and change db name be consistent with file name in…
hustjieke Jan 13, 2023
eae52b4
Merge branch 'stonedb-5.7-dev' into fix_limit_unsigned_integer_to_sig…
mergify[bot] Jan 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
192 changes: 192 additions & 0 deletions mysql-test/suite/tianmu/r/out_of_range_issue1151.result
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,192 @@
drop database if exists out_of_range_issue1151;
Warnings:
Note 1008 Can't drop database 'out_of_range_issue1151'; database doesn't exist
create database out_of_range_issue1151;
use out_of_range_issue1151;
create table tiny(a tinyint, b tinyint unsigned) engine = tianmu DEFAULT CHARSET=utf8mb4;
insert into tiny values(-128, 0);
insert into tiny values(127, 127);
insert into tiny values(0, 127);
insert into tiny values(-0, -0);
insert into tiny values(+0, +0);
select * from tiny;
a b
-128 0
127 127
0 127
0 0
0 0
insert into tiny values(-129, 0);
ERROR 22003: Out of range value for column 'a' at row 1
insert into tiny values(128, 0);
ERROR 22003: Out of range value for column 'a' at row 1
insert into tiny values(1234, 0);
ERROR 22003: Out of range value for column 'a' at row 1
insert into tiny values(0, 128);
ERROR 22003: Out of range[0, 127] for column 'b' value: 128
insert into tiny values(0, 255);
ERROR 22003: Out of range[0, 127] for column 'b' value: 255
insert into tiny values(0, -1);
ERROR 22003: Out of range value for column 'b' at row 1
insert into tiny values(0, -127);
ERROR 22003: Out of range value for column 'b' at row 1
insert into tiny values(0, 256);
ERROR 22003: Out of range value for column 'b' at row 1
insert into tiny values(0, 1234567);
ERROR 22003: Out of range value for column 'b' at row 1
drop table tiny;
create table small(a smallint, b smallint unsigned) engine = tianmu DEFAULT CHARSET=utf8mb4;
insert into small values(-32768, 0);
insert into small values(0, 0);
insert into small values(122, 122);
insert into small values(32767, 32767);
insert into small values(-0, -0);
insert into small values(+0, +0);
select * from small;
a b
-32768 0
0 0
122 122
32767 32767
0 0
0 0
insert into small values(-32769, 0);
ERROR 22003: Out of range value for column 'a' at row 1
insert into small values(32768, 0);
ERROR 22003: Out of range value for column 'a' at row 1
insert into small values(-3276911, 0);
ERROR 22003: Out of range value for column 'a' at row 1
insert into small values(3276811, 0);
ERROR 22003: Out of range value for column 'a' at row 1
insert into small values(0, 32768);
ERROR 22003: Out of range[0, 32767] for column 'b' value: 32768
insert into small values(0, 41234);
ERROR 22003: Out of range[0, 32767] for column 'b' value: 41234
insert into small values(0, 65535);
ERROR 22003: Out of range[0, 32767] for column 'b' value: 65535
insert into small values(0, -1);
ERROR 22003: Out of range value for column 'b' at row 1
insert into small values(0, -32768);
ERROR 22003: Out of range value for column 'b' at row 1
insert into small values(0, 65536);
ERROR 22003: Out of range value for column 'b' at row 1
insert into small values(0, 1234567);
ERROR 22003: Out of range value for column 'b' at row 1
drop table small;
create table medium(a mediumint, b mediumint unsigned) engine = tianmu DEFAULT CHARSET=utf8mb4;
insert into medium values(-8388608, 0);
insert into medium values(0, 0);
insert into medium values(122, 122);
insert into medium values(8388607, 8388607);
insert into medium values(-0, -0);
insert into medium values(+0, +0);
select * from medium;
a b
-8388608 0
0 0
122 122
8388607 8388607
0 0
0 0
insert into medium values(-8388609, 0);
ERROR 22003: Out of range value for column 'a' at row 1
insert into medium values(8388608, 0);
ERROR 22003: Out of range value for column 'a' at row 1
insert into medium values(-8388608111, 0);
ERROR 22003: Out of range value for column 'a' at row 1
insert into medium values(8388608111, 0);
ERROR 22003: Out of range value for column 'a' at row 1
insert into medium values(0, 8388608);
ERROR 22003: Out of range[0, 8388607] for column 'b' value: 8388608
insert into medium values(0, 8388610);
ERROR 22003: Out of range[0, 8388607] for column 'b' value: 8388610
insert into medium values(0, 16777215);
ERROR 22003: Out of range[0, 8388607] for column 'b' value: 16777215
insert into medium values(0, -1);
ERROR 22003: Out of range value for column 'b' at row 1
insert into medium values(0, -8388608);
ERROR 22003: Out of range value for column 'b' at row 1
insert into medium values(0, 16777216);
ERROR 22003: Out of range value for column 'b' at row 1
insert into medium values(0, 1677721511);
ERROR 22003: Out of range value for column 'b' at row 1
drop table medium;
create table int_(a int, b int unsigned) engine = tianmu DEFAULT CHARSET=utf8mb4;
insert into int_ values(-2147483647, 0);
insert into int_ values(0, 0);
insert into int_ values(122, 122);
insert into int_ values(2147483647, 2147483647);
insert into int_ values(-0, -0);
insert into int_ values(+0, +0);
select * from int_;
a b
-2147483647 0
0 0
122 122
2147483647 2147483647
0 0
0 0
insert into int_ values(-2147483649, 0);
ERROR 22003: Out of range value for column 'a' at row 1
insert into int_ values(2147483648, 0);
ERROR 22003: Out of range value for column 'a' at row 1
insert into int_ values(-214748364811, 0);
ERROR 22003: Out of range value for column 'a' at row 1
insert into int_ values(214748364811, 0);
ERROR 22003: Out of range value for column 'a' at row 1
insert into int_ values(-2147483648, 0);
ERROR 22003: Out of range[-2147483647, 2147483647] for column 'a' value: -2147483648
insert into int_ values(0, 2147483648);
ERROR 22003: Out of range[0, 2147483647] for column 'b' value: 2147483648
insert into int_ values(0, 3294967295);
ERROR 22003: Out of range[0, 2147483647] for column 'b' value: 3294967295
insert into int_ values(0, 4294967295);
ERROR 22003: Out of range[0, 2147483647] for column 'b' value: 4294967295
insert into int_ values(0, -1);
ERROR 22003: Out of range value for column 'b' at row 1
insert into int_ values(0, -4294967295);
ERROR 22003: Out of range value for column 'b' at row 1
insert into int_ values(0, 4294967296);
ERROR 22003: Out of range value for column 'b' at row 1
insert into int_ values(0, 429496729611);
ERROR 22003: Out of range value for column 'b' at row 1
drop table int_;
create table bigint_(a bigint, b bigint unsigned) engine = tianmu DEFAULT CHARSET=utf8mb4;
insert into bigint_ values(-9223372036854775806, 0);
insert into bigint_ values(0, 0);
insert into bigint_ values(122, 122);
insert into bigint_ values(9223372036854775807, 9223372036854775807);
insert into bigint_ values(-0, -0);
insert into bigint_ values(+0, +0);
select * from bigint_;
a b
-9223372036854775806 0
0 0
122 122
9223372036854775807 9223372036854775807
0 0
0 0
insert into bigint_ values(-9223372036854775808, 0);
ERROR 22003: Out of range[-9223372036854775807, 9223372036854775807] for column 'a' value: -9223372036854775808
insert into bigint_ values(9223372036854775808, 0);
ERROR 22003: Out of range value for column 'a' at row 1
insert into bigint_ values(-9223372036854775810, 0);
ERROR 22003: Out of range value for column 'a' at row 1
insert into bigint_ values(9223372036854775810, 0);
ERROR 22003: Out of range value for column 'a' at row 1
insert into bigint_ values(0, 9223372036854775808);
ERROR 22003: Out of range[0, 9223372036854775807] for column 'b' value: 9223372036854775808
insert into bigint_ values(0, 10223372036854775808);
ERROR 22003: Out of range[0, 9223372036854775807] for column 'b' value: 10223372036854775808
insert into bigint_ values(0, 18446744073709551615);
ERROR 22003: Out of range[0, 9223372036854775807] for column 'b' value: 18446744073709551615
insert into bigint_ values(0, -1);
ERROR 22003: Out of range value for column 'b' at row 1
insert into bigint_ values(0, -4294967295);
ERROR 22003: Out of range value for column 'b' at row 1
insert into bigint_ values(0, 18446744073709551616);
ERROR 22003: Out of range value for column 'b' at row 1
insert into bigint_ values(0, 1844674407370955161566);
ERROR 22003: Out of range value for column 'b' at row 1
drop table bigint_;
drop database if exists out_of_range_issue1151;
11 changes: 7 additions & 4 deletions ...l-test/suite/tianmu/t/auto_increment.test → ...est/suite/tianmu/t/auto_increment.testbak
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,8 @@ CREATE TABLE tintu (
PRIMARY KEY (id)
) engine=tianmu;

insert into tintu (id, data) values(4294967294, "first"),(63, "middle"),(0, "last");
#insert into tintu (id, data) values(4294967294, "first"),(63, "middle"),(0, "last");
insert into tintu (id, data) values(2147483647, "first"),(63, "middle"),(0, "last");
select * from tintu;
--error 1062
insert into tintu (id, data) values (0, "last");
Expand Down Expand Up @@ -123,7 +124,8 @@ CREATE TABLE tmediumintu (
PRIMARY KEY (id)
) engine=tianmu;

insert into tmediumintu (id, data) values(16777214, "first"),(63, "middle"),(0, "last");
#insert into tmediumintu (id, data) values(16777214, "first"),(63, "middle"),(0, "last");
insert into tmediumintu (id, data) values(8388607, "first"),(63, "middle"),(0, "last");
select * from tmediumintu;
--error 1062
insert into tmediumintu (id, data) values (0, "last");
Expand All @@ -135,7 +137,8 @@ CREATE TABLE tbigintu (
PRIMARY KEY (id)
) engine=tianmu;

insert into tbigintu (id, data) values(18446744073709551614, "first"),(63, "middle"),(0, "last");
#insert into tbigintu (id, data) values(18446744073709551614, "first"),(63, "middle"),(0, "last");
insert into tbigintu (id, data) values(9223372036854775807, "first"),(63, "middle"),(0, "last");
select * from tbigintu;
--error 1062
insert into tbigintu (id, data) values (0, "last");
Expand All @@ -152,4 +155,4 @@ eval LOAD DATA LOCAL INFILE '$MYSQL_TEST_DIR/suite/tianmu/std_data/auto_incremen
select * from auto_increment_negative;

# Clean UP
DROP DATABASE auto_increment_db;
DROP DATABASE auto_increment_db;
Loading