Refactor Minting Fee and Receiver Check Hooks into Unified LicensingHook#115
Merged
kingster-will merged 5 commits intostoryprotocol:mainfrom Apr 23, 2024
Merged
Conversation
kingster-will
requested review from
AndyBoWu,
LeoHChen,
Ramarti,
Spablob,
jdubpark and
leeren
as code owners
Collaborator
Author
|
Closes #116 |
LeoHChen
reviewed
Apr 17, 2024
LeoHChen
approved these changes
Apr 19, 2024
|
please rebase the code. @kingster-will |
kingster-will
force-pushed
the
v1/licensing-hook
branch
from
697da52 to
608ece8
Compare
Collaborator
Author
rebased. |
- Fix deep stack issue in DeployHelper
kingster-will
force-pushed
the
v1/licensing-hook
branch
from
608ece8 to
f2ce7ee
Compare
Spablob
reviewed
Apr 23, 2024
Spablob
reviewed
Apr 23, 2024
Spablob
reviewed
Apr 23, 2024
Spablob
approved these changes
Apr 23, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces a refactor of the minting fee and receiver check hooks. The two separate hooks have been unified into a single LicensingHook, which provides a more streamlined and efficient way for developers to implement custom logic before minting tokens or registering derivatives.
Testing:
100% test coverage for the changed code.