Single DeployHelper for Deployment and Tests#36
Merged
LeoHChen merged 15 commits intostoryprotocol:mainfrom Apr 9, 2024
Merged
Single DeployHelper for Deployment and Tests#36LeoHChen merged 15 commits intostoryprotocol:mainfrom
LeoHChen merged 15 commits intostoryprotocol:mainfrom
Conversation
jdubpark
changed the title
Ramarti
approved these changes
Apr 5, 2024
- Use new BaseTest and remove mock deployers - Modify some tests to clarify on caller using vm prank - Minor lint fixes for state variable visibility - Mock royalty policy LAP - Prepare codebase structure to remove some mocks in next PR - Remove unused test files
jdubpark
requested review from
AndyBoWu,
LeoHChen,
Spablob,
kingster-will and
leeren
as code owners
LeoHChen
approved these changes
Apr 8, 2024
kingster-will
approved these changes
Apr 8, 2024
kingster-will
pushed a commit
to kingster-will/protocol-core-v1-dev
that referenced
this pull request
Jan 31, 2025
kingster-will
pushed a commit
that referenced
this pull request
Jan 31, 2025
irfand29
pushed a commit
to irfand29/protocol-core-v1
that referenced
this pull request
Feb 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Currently, the codebase contains two separate main deployment helpers, one inherited by all tests and another for the actual protocol deployment. Keeping these two files synced can lead to disparity, thus this PR intends to merge the two together to create a unified deploy helper.
Changes
All changes were made in the script & test folders
Misc.
After this PR, we intend to