Integrate Tests with the New License System#37
Merged
LeoHChen merged 12 commits intostoryprotocol:mainfrom Apr 9, 2024
Merged
Conversation
jdubpark
requested review from
AndyBoWu,
LeoHChen,
Ramarti,
Spablob,
kingster-will and
leeren
as code owners
- Use new BaseTest and remove mock deployers - Modify some tests to clarify on caller using vm prank - Minor lint fixes for state variable visibility - Mock royalty policy LAP - Prepare codebase structure to remove some mocks in next PR - Remove unused test files
jdubpark
force-pushed
the
test-integrate-license
branch
from
c416cf8 to
a091a41
Compare
LeoHChen
approved these changes
Apr 9, 2024
Spablob
approved these changes
Apr 9, 2024
kingster-will
added a commit
to kingster-will/protocol-core-v1-dev
that referenced
this pull request
Jan 18, 2025
…store Use Transient State for IPGraph ACL to Save Gas
kingster-will
added a commit
to kingster-will/protocol-core-v1-dev
that referenced
this pull request
Jan 31, 2025
kingster-will
added a commit
that referenced
this pull request
Jan 31, 2025
irfand29
pushed a commit
to irfand29/protocol-core-v1
that referenced
this pull request
Feb 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-enable all protocol tests disabled in PR #33 by integrating the new license system into existing tests.
Additionally, it removes all the PIL Policy Framework tests as the structure of the PIL and license system has changed significantly. We will require more tests for the new PILicenseTemplate that closely reflects the previous test cases of the PIL Policy Framework.
Note: Branched off #36, requires merging #36 first before this PR.