Enforce a minimum duration to cache capabilities.#783
Merged
Conversation
Simply using the values from the "Cache-Control" header is problematic as recent setups of Nextcloud are not setting the header and capabilities would not be cached at all in these cases.
Pull Request Test Coverage Report for Build 10139210597Details
💛 - Coveralls |
SystemKeeper
approved these changes
Jul 29, 2024
Member
Author
|
Thanks for testing! |
This was referenced Jul 29, 2024
Merged
mwalbeck
pushed a commit
to mwalbeck/docker-nextcloud-spreed-signaling
that referenced
this pull request
Sep 13, 2024
This PR contains the following updates: | Package | Update | Change | |---|---|---| | [strukturag/nextcloud-spreed-signaling](https://github.com/strukturag/nextcloud-spreed-signaling) | major | `v1.3.2` -> `v2.0.0` | --- ### Release Notes <details> <summary>strukturag/nextcloud-spreed-signaling (strukturag/nextcloud-spreed-signaling)</summary> ### [`v2.0.0`](https://github.com/strukturag/nextcloud-spreed-signaling/releases/tag/v2.0.0) [Compare Source](strukturag/nextcloud-spreed-signaling@v1.3.2...v2.0.0) ##### Added - Federation support [#​776](strukturag/nextcloud-spreed-signaling#776) - CI: Add job to update generated files. [#​790](strukturag/nextcloud-spreed-signaling#790) - Expose backend session limits through prometheus stats. [#​792](strukturag/nextcloud-spreed-signaling#792) - CI: Test with Golang 1.23 [#​805](strukturag/nextcloud-spreed-signaling#805) ##### Changed - Keep generated files in the repository. [#​781](strukturag/nextcloud-spreed-signaling#781) - Improve caching when fetching capabilities. [#​780](strukturag/nextcloud-spreed-signaling#780) - Enforce a minimum duration to cache capabilities. [#​783](strukturag/nextcloud-spreed-signaling#783) - docs: Use the latest LTS of Ubuntu and Python 3.12. [#​791](strukturag/nextcloud-spreed-signaling#791) - CI: Push generated code from service account. [#​793](strukturag/nextcloud-spreed-signaling#793) - CI: Only build code if token exists (i.e. with Dependabot). [#​794](strukturag/nextcloud-spreed-signaling#794) - CI: Always do a full build of generated files. [#​795](strukturag/nextcloud-spreed-signaling#795) - Remove compatibility code for Go < 1.21. [#​806](strukturag/nextcloud-spreed-signaling#806) - Send ping requests to local instance for federated sessions. [#​808](strukturag/nextcloud-spreed-signaling#808) ##### Dependencies - Bump sphinx from 7.3.7 to 7.4.4 in /docs [#​773](strukturag/nextcloud-spreed-signaling#773) - Bump google.golang.org/grpc from 1.64.0 to 1.65.0 [#​769](strukturag/nextcloud-spreed-signaling#769) - Bump sphinx from 7.4.4 to 7.4.5 in /docs [#​774](strukturag/nextcloud-spreed-signaling#774) - Bump github.com/nats-io/nats-server/v2 from 2.10.17 to 2.10.18 [#​775](strukturag/nextcloud-spreed-signaling#775) - Bump sphinx from 7.4.5 to 7.4.6 in /docs [#​777](strukturag/nextcloud-spreed-signaling#777) - Bump sphinx from 7.4.6 to 7.4.7 in /docs [#​779](strukturag/nextcloud-spreed-signaling#779) - Bump the etcd group with 4 updates [#​778](strukturag/nextcloud-spreed-signaling#778) - Bump golangci/golangci-lint-action from 6.0.1 to 6.1.0 [#​788](strukturag/nextcloud-spreed-signaling#788) - Bump google.golang.org/grpc/cmd/protoc-gen-go-grpc from 1.4.0 to 1.5.1 [#​784](strukturag/nextcloud-spreed-signaling#784) - Bump markdown from 3.6 to 3.7 in /docs [#​801](strukturag/nextcloud-spreed-signaling#801) - Bump github.com/prometheus/client_golang from 1.19.1 to 1.20.2 [#​803](strukturag/nextcloud-spreed-signaling#803) - Bump golang from 1.22-alpine to 1.23-alpine in /docker/server [#​798](strukturag/nextcloud-spreed-signaling#798) - Bump golang from 1.22-alpine to 1.23-alpine in /docker/proxy [#​799](strukturag/nextcloud-spreed-signaling#799) - Bump google.golang.org/grpc from 1.65.0 to 1.66.0 [#​810](strukturag/nextcloud-spreed-signaling#810) - Bump github.com/nats-io/nats-server/v2 from 2.10.18 to 2.10.19 [#​809](strukturag/nextcloud-spreed-signaling#809) - Bump github.com/nats-io/nats.go from 1.36.0 to 1.37.0 [#​797](strukturag/nextcloud-spreed-signaling#797) - Bump mkdocs from 1.6.0 to 1.6.1 in /docs [#​812](strukturag/nextcloud-spreed-signaling#812) - Bump github.com/nats-io/nats-server/v2 from 2.10.19 to 2.10.20 [#​813](strukturag/nextcloud-spreed-signaling#813) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC41OS4zIiwidXBkYXRlZEluVmVyIjoiMzguNTkuMyIsInRhcmdldEJyYW5jaCI6Im1hc3RlciIsImxhYmVscyI6W119--> Reviewed-on: https://git.walbeck.it/walbeck-it/docker-nextcloud-spreed-signaling/pulls/504 Co-authored-by: renovate-bot <bot@walbeck.it> Co-committed-by: renovate-bot <bot@walbeck.it>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simply using the values from the "Cache-Control" header is problematic as recent setups of Nextcloud are not setting the header and capabilities would not be cached at all in these cases.
Follow-up to #780
@SystemKeeper PTAL