Send ping requests to local instance for federated sessions. by fancycode · Pull Request #808 · strukturag/nextcloud-spreed-signaling

fancycode · 2024-08-28T09:48:42Z

coveralls · 2024-08-28T10:04:31Z

Pull Request Test Coverage Report for Build 10616567159

Details

127 of 153 (83.01%) changed or added relevant lines in 8 files are covered.
15 unchanged lines in 6 files lost coverage.
Overall coverage increased (+0.1%) to 58.487%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
clientsession.go	12	14	85.71%
room_ping.go	17	20	85.0%
virtualsession.go	5	8	62.5%
session.go	6	10	60.0%
hub.go	66	80	82.5%

Files with Coverage Reduction	New Missed Lines	%
room_ping.go	1	89.05%
grpc_client.go	2	79.0%
mcu_proxy.go	2	60.78%
clientsession.go	2	67.79%
federation.go	4	78.83%
dns_monitor.go	4	94.12%

Totals
Change from base Build 10610962373:	0.1%
Covered Lines:	10585
Relevant Lines:	18098

💛 - Coveralls

This allows using a single signaling server with two Nextcloud instances during development.

nickvergessen

Tested successfully now

This PR contains the following updates: | Package | Update | Change | |---|---|---| | [strukturag/nextcloud-spreed-signaling](https://github.com/strukturag/nextcloud-spreed-signaling) | major | `v1.3.2` -> `v2.0.0` | --- ### Release Notes <details> <summary>strukturag/nextcloud-spreed-signaling (strukturag/nextcloud-spreed-signaling)</summary> ### [`v2.0.0`](https://github.com/strukturag/nextcloud-spreed-signaling/releases/tag/v2.0.0) [Compare Source](strukturag/nextcloud-spreed-signaling@v1.3.2...v2.0.0) ##### Added - Federation support [#776](strukturag/nextcloud-spreed-signaling#776) - CI: Add job to update generated files. [#790](strukturag/nextcloud-spreed-signaling#790) - Expose backend session limits through prometheus stats. [#792](strukturag/nextcloud-spreed-signaling#792) - CI: Test with Golang 1.23 [#805](strukturag/nextcloud-spreed-signaling#805) ##### Changed - Keep generated files in the repository. [#781](strukturag/nextcloud-spreed-signaling#781) - Improve caching when fetching capabilities. [#780](strukturag/nextcloud-spreed-signaling#780) - Enforce a minimum duration to cache capabilities. [#783](strukturag/nextcloud-spreed-signaling#783) - docs: Use the latest LTS of Ubuntu and Python 3.12. [#791](strukturag/nextcloud-spreed-signaling#791) - CI: Push generated code from service account. [#793](strukturag/nextcloud-spreed-signaling#793) - CI: Only build code if token exists (i.e. with Dependabot). [#794](strukturag/nextcloud-spreed-signaling#794) - CI: Always do a full build of generated files. [#795](strukturag/nextcloud-spreed-signaling#795) - Remove compatibility code for Go < 1.21. [#806](strukturag/nextcloud-spreed-signaling#806) - Send ping requests to local instance for federated sessions. [#808](strukturag/nextcloud-spreed-signaling#808) ##### Dependencies - Bump sphinx from 7.3.7 to 7.4.4 in /docs [#773](strukturag/nextcloud-spreed-signaling#773) - Bump google.golang.org/grpc from 1.64.0 to 1.65.0 [#769](strukturag/nextcloud-spreed-signaling#769) - Bump sphinx from 7.4.4 to 7.4.5 in /docs [#774](strukturag/nextcloud-spreed-signaling#774) - Bump github.com/nats-io/nats-server/v2 from 2.10.17 to 2.10.18 [#775](strukturag/nextcloud-spreed-signaling#775) - Bump sphinx from 7.4.5 to 7.4.6 in /docs [#777](strukturag/nextcloud-spreed-signaling#777) - Bump sphinx from 7.4.6 to 7.4.7 in /docs [#779](strukturag/nextcloud-spreed-signaling#779) - Bump the etcd group with 4 updates [#778](strukturag/nextcloud-spreed-signaling#778) - Bump golangci/golangci-lint-action from 6.0.1 to 6.1.0 [#788](strukturag/nextcloud-spreed-signaling#788) - Bump google.golang.org/grpc/cmd/protoc-gen-go-grpc from 1.4.0 to 1.5.1 [#784](strukturag/nextcloud-spreed-signaling#784) - Bump markdown from 3.6 to 3.7 in /docs [#801](strukturag/nextcloud-spreed-signaling#801) - Bump github.com/prometheus/client_golang from 1.19.1 to 1.20.2 [#803](strukturag/nextcloud-spreed-signaling#803) - Bump golang from 1.22-alpine to 1.23-alpine in /docker/server [#798](strukturag/nextcloud-spreed-signaling#798) - Bump golang from 1.22-alpine to 1.23-alpine in /docker/proxy [#799](strukturag/nextcloud-spreed-signaling#799) - Bump google.golang.org/grpc from 1.65.0 to 1.66.0 [#810](strukturag/nextcloud-spreed-signaling#810) - Bump github.com/nats-io/nats-server/v2 from 2.10.18 to 2.10.19 [#809](strukturag/nextcloud-spreed-signaling#809) - Bump github.com/nats-io/nats.go from 1.36.0 to 1.37.0 [#797](strukturag/nextcloud-spreed-signaling#797) - Bump mkdocs from 1.6.0 to 1.6.1 in /docs [#812](strukturag/nextcloud-spreed-signaling#812) - Bump github.com/nats-io/nats-server/v2 from 2.10.19 to 2.10.20 [#813](strukturag/nextcloud-spreed-signaling#813) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).  Reviewed-on: https://git.walbeck.it/walbeck-it/docker-nextcloud-spreed-signaling/pulls/504 Co-authored-by: renovate-bot <bot@walbeck.it> Co-committed-by: renovate-bot <bot@walbeck.it>

fancycode added 3 commits August 28, 2024 09:12

Pass room id when triggering pings.

dcff6d2

Send ping requests to local instance for federated sessions.

bfefcfe

Signaling servers should not form a cluster in federation tests.

75f6b1b

fancycode added 2 commits August 28, 2024 14:26

Return number of ping entries, not number of urls processed.

0490cca

Add tests for federated room pings.

d6cdb7b

fancycode marked this pull request as ready for review August 28, 2024 12:29

fancycode mentioned this pull request Aug 29, 2024

Federated call ends after some time without a local participant nextcloud/spreed#12917

Closed

Prefix room session id for sessions that get federated.

b233651

This allows using a single signaling server with two Nextcloud instances during development.

nickvergessen approved these changes Aug 29, 2024

View reviewed changes

Add helper method to get parsed userdata from a session.

825cab1

fancycode force-pushed the federation-pings branch from 238ed65 to 81140ba Compare August 29, 2024 13:39

Include actor information in room join/leave events for fed. sessions.

7f03fff

fancycode force-pushed the federation-pings branch from 81140ba to 7f03fff Compare August 29, 2024 14:00

fancycode merged commit 628642a into master Aug 29, 2024

fancycode deleted the federation-pings branch August 29, 2024 14:04

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Send ping requests to local instance for federated sessions.#808

Send ping requests to local instance for federated sessions.#808
fancycode merged 8 commits intomasterfrom
federation-pings

fancycode commented Aug 28, 2024

Uh oh!

coveralls commented Aug 28, 2024 •

edited

Loading

Uh oh!

nickvergessen left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Comments

Conversation

fancycode commented Aug 28, 2024

Uh oh!

coveralls commented Aug 28, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pull Request Test Coverage Report for Build 10616567159

Details

💛 - Coveralls

Uh oh!

nickvergessen left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Comments

coveralls commented Aug 28, 2024 •

edited

Loading