feat(filesystem): define From<Fatfs Error> trait for VfsErrorKind #554
+50
−21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Koichi Imai <[email protected]>
Signed-off-by: Koichi Imai <[email protected]>
Signed-off-by: Koichi Imai <[email protected]>
Signed-off-by: Koichi Imai <[email protected]>
Signed-off-by: Koichi Imai <[email protected]>
Koichi98
changed the title
Koichi98
changed the title
veqcc
approved these changes
Jul 1, 2025
ytakano
approved these changes
Jul 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implemented From trait for Fatfs Error type to VfsErrorKind.
I also have added some of the Fatfs Error variables to VfsErrorKind.
Since there's no way to distinguish file and directory "AlreadyExists" Error in Fatfs, I have deleted "FileExists" and "DirectoryExists" from VfsErrorKind. (We actually can distinguish file and directory in Fatfs too but we need to fix a lot to do that. Also, I don't think it's all that necessary to strictly differentiate between FileExists and DirectoryExists when returning error types.)
Related links
#549 (Fatfs Error type PR)
#548 (VfsError introducing PR)
#511
How was this PR tested?
Notes for reviewers