fix(filesystem): Error type only for fatfs #549
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Koichi <[email protected]>
Signed-off-by: Koichi <[email protected]>
Signed-off-by: Koichi <[email protected]>
Signed-off-by: Koichi <[email protected]>
Signed-off-by: Koichi <[email protected]>
Signed-off-by: Koichi <[email protected]>
Signed-off-by: Koichi <[email protected]>
Signed-off-by: Koichi <[email protected]>
Signed-off-by: Koichi <[email protected]>
Signed-off-by: Koichi Imai <[email protected]>
…fix/error_for_fatfs
veqcc
approved these changes
Jul 1, 2025
ytakano
approved these changes
Jul 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Initially, in PR #482 , I have placed the fatfs Error type(error.rs) in awkernel_lib/src/file/, not in awkernel_lib/src/file/fatfs/. The intention was to use it as the generic filesystem Error type for Awkernel. However, with the introduction of VFS (Virtual File System), the error type returned to user applications became VfsError. Therefore, I reverted the original Error type back to being fatfs specific.
Moving forward, each filesystem will maintain its own unique error type. We'll then define conversion functions (From) between these specific error types and VfsError, allowing VfsError to be returned consistently.
Related links
PR #511
How was this PR tested?
Notes for reviewers