Skip to content

Conversation

@Koichi98
Copy link
Contributor

@Koichi98 Koichi98 commented Jun 10, 2025

Description

In a previous pull request, FatFs was introduced as a sub-crate directly under the project directory, similar to smoltcp. However, this pull request moves it into awkernel_lib.

When moving the FatFs crate, we're also elevating io.rs and error.rs to a higher level in the module hierarchy, above the FatFs module itself. This is a deliberate design choice, as it allows other file systems to leverage these shared traits and error types.

awkernel_lib/src/file$ tree
.
├── error.rs
├── fatfs
│   ├── boot_sector.rs
│   ├── dir_entry.rs
│   ├── dir.rs
│   ├── file.rs
│   ├── fs.rs
│   ├── LICENSE.txt
│   ├── table.rs
│   └── time.rs
├── fatfs.rs
├── io.rs

Related links

PR #444

How was this PR tested?

Notes for reviewers

Koichi98 and others added 30 commits April 17, 2025 11:01
Signed-off-by: Koichi Imai <[email protected]>
Signed-off-by: Koichi Imai <[email protected]>
Signed-off-by: koichiimai <[email protected]>
Signed-off-by: Koichi Imai <[email protected]>
Signed-off-by: koichiimai <[email protected]>
Signed-off-by: Koichi Imai <[email protected]>
Signed-off-by: Koichi Imai <[email protected]>
Signed-off-by: Koichi Imai <[email protected]>
Signed-off-by: Koichi Imai <[email protected]>
Signed-off-by: Koichi Imai <[email protected]>
Signed-off-by: Koichi Imai <[email protected]>
Signed-off-by: Koichi Imai <[email protected]>
Signed-off-by: Koichi Imai <[email protected]>
Signed-off-by: Koichi Imai <[email protected]>
Signed-off-by: Koichi Imai <[email protected]>
Signed-off-by: Koichi Imai <[email protected]>
Signed-off-by: Koichi Imai <[email protected]>
Signed-off-by: Koichi Imai <[email protected]>
Signed-off-by: Koichi Imai <[email protected]>
Signed-off-by: Koichi <[email protected]>
Signed-off-by: Koichi Imai <[email protected]>
Signed-off-by: Koichi Imai <[email protected]>
Signed-off-by: Koichi Imai <[email protected]>
Signed-off-by: Koichi Imai <[email protected]>
Signed-off-by: Koichi Imai <[email protected]>
Signed-off-by: Koichi Imai <[email protected]>
Koichi98 and others added 21 commits June 5, 2025 15:09
Signed-off-by: Koichi Imai <[email protected]>
Signed-off-by: Koichi Imai <[email protected]>
Signed-off-by: Koichi Imai <[email protected]>
Signed-off-by: Koichi <[email protected]>
Signed-off-by: Koichi <[email protected]>
Signed-off-by: Koichi <[email protected]>
Signed-off-by: Koichi <[email protected]>
Signed-off-by: Koichi Imai <[email protected]>
Signed-off-by: Koichi Imai <[email protected]>
Signed-off-by: Koichi Imai <[email protected]>
Signed-off-by: Koichi Imai <[email protected]>
Signed-off-by: Koichi <[email protected]>
Signed-off-by: Koichi <[email protected]>
Signed-off-by: Koichi <[email protected]>
Signed-off-by: Koichi <[email protected]>
Signed-off-by: Koichi <[email protected]>
Signed-off-by: Koichi <[email protected]>
@Koichi98 Koichi98 mentioned this pull request Jun 10, 2025
16 tasks
@Koichi98 Koichi98 marked this pull request as ready for review June 10, 2025 04:37
@Koichi98 Koichi98 requested a review from ytakano June 10, 2025 04:37
@ytakano ytakano merged commit 1679d1d into main Jun 10, 2025
1 check passed
@ytakano ytakano deleted the introduce_fatfs_as_lib branch June 10, 2025 05:20
@Koichi98 Koichi98 self-assigned this Jul 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants