🐛 fix(ci): Disable npm cache for electron builds to fix binary corruption#152
Merged
trickpatty merged 1 commit intomainfrom Jan 22, 2026
Merged
Conversation
…tion Root cause: GitHub Actions npm cache can corrupt or incompletely cache large binary packages like app-builder-bin (~50MB). When npm ci restores from this corrupted cache, the binaries are missing or incomplete. Evidence: - macOS builds failed at verification (binary didn't exist) - Linux/Windows passed verification but failed at build (corrupted binaries) - npm rebuild doesn't help because app-builder-bin has no build scripts Solution: Remove npm caching for the four electron build jobs (Linux, Windows, macOS Intel, macOS ARM). These jobs run infrequently (only on push to main or releases), so the performance impact is minimal. The build-and-test and security-audit jobs keep npm caching since they don't use electron-builder.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root cause: GitHub Actions npm cache can corrupt or incompletely cache large binary packages like app-builder-bin (~50MB). When npm ci restores from this corrupted cache, the binaries are missing or incomplete.
Evidence:
Solution: Remove npm caching for the four electron build jobs (Linux, Windows, macOS Intel, macOS ARM). These jobs run infrequently (only on push to main or releases), so the performance impact is minimal.
The build-and-test and security-audit jobs keep npm caching since they don't use electron-builder.