Skip to content

🐛 fix(ci): Disable npm cache for electron builds to fix binary corruption #152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
trickpatty merged 1 commit into from
Jan 22, 2026
Merged

🐛 fix(ci): Disable npm cache for electron builds to fix binary corruption #152

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
64 changes: 4 additions & 60 deletions .github/workflows/electron.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,26 +211,12 @@ jobs:
uses: actions/setup-node@v6
with:
node-version: ${{ env.NODE_VERSION }}
cache: 'npm'
cache-dependency-path: './clients/package-lock.json'
# Note: npm cache disabled for electron builds due to app-builder-bin binary corruption issues

- name: Install dependencies
run: npm ci
working-directory: ./clients

# Verify app-builder-bin binary exists (GitHub Actions cache may not extract binaries correctly)
- name: Verify app-builder-bin installation
working-directory: ./clients
run: |
BINARY_PATH="node_modules/app-builder-bin/linux/x64/app-builder"
if [ ! -f "$BINARY_PATH" ]; then
echo "::warning::app-builder-bin binary not found, reinstalling..."
npm install app-builder-bin@5.0.0-alpha.10 --force
fi
chmod +x "$BINARY_PATH"
echo "Binary verified:"
ls -la "$BINARY_PATH"

- name: Configure environment URLs
run: |
ENV="${{ needs.fetch-azure-config.outputs.environment }}"
Expand Down Expand Up @@ -310,26 +296,12 @@ jobs:
uses: actions/setup-node@v6
with:
node-version: ${{ env.NODE_VERSION }}
cache: 'npm'
cache-dependency-path: './clients/package-lock.json'
# Note: npm cache disabled for electron builds due to app-builder-bin binary corruption issues

- name: Install dependencies
run: npm ci
working-directory: ./clients

# Verify app-builder-bin binary exists (GitHub Actions cache may not extract binaries correctly)
- name: Verify app-builder-bin installation
shell: pwsh
working-directory: ./clients
run: |
$BINARY_PATH = "node_modules\app-builder-bin\win\x64\app-builder.exe"
if (-not (Test-Path $BINARY_PATH)) {
Write-Host "::warning::app-builder-bin binary not found, reinstalling..."
npm install app-builder-bin@5.0.0-alpha.10 --force
}
Write-Host "Binary verified:"
Get-Item $BINARY_PATH

- name: Configure environment URLs
shell: pwsh
run: |
Expand Down Expand Up @@ -424,26 +396,12 @@ jobs:
uses: actions/setup-node@v6
with:
node-version: ${{ env.NODE_VERSION }}
cache: 'npm'
cache-dependency-path: './clients/package-lock.json'
# Note: npm cache disabled for electron builds due to app-builder-bin binary corruption issues

- name: Install dependencies
run: npm ci
working-directory: ./clients

# Verify app-builder-bin binary exists (GitHub Actions cache may not extract binaries correctly)
- name: Verify app-builder-bin installation
working-directory: ./clients
run: |
BINARY_PATH="node_modules/app-builder-bin/mac/app-builder"
if [ ! -f "$BINARY_PATH" ]; then
echo "::warning::app-builder-bin binary not found, reinstalling..."
npm install app-builder-bin@5.0.0-alpha.10 --force
fi
chmod +x "$BINARY_PATH"
echo "Binary verified:"
ls -la "$BINARY_PATH"

- name: Configure environment URLs
run: |
ENV="${{ needs.fetch-azure-config.outputs.environment }}"
Expand Down Expand Up @@ -541,26 +499,12 @@ jobs:
uses: actions/setup-node@v6
with:
node-version: ${{ env.NODE_VERSION }}
cache: 'npm'
cache-dependency-path: './clients/package-lock.json'
# Note: npm cache disabled for electron builds due to app-builder-bin binary corruption issues

- name: Install dependencies
run: npm ci
working-directory: ./clients

# Verify app-builder-bin binary exists (GitHub Actions cache may not extract binaries correctly)
- name: Verify app-builder-bin installation
working-directory: ./clients
run: |
BINARY_PATH="node_modules/app-builder-bin/mac/app-builder"
if [ ! -f "$BINARY_PATH" ]; then
echo "::warning::app-builder-bin binary not found, reinstalling..."
npm install app-builder-bin@5.0.0-alpha.10 --force
fi
chmod +x "$BINARY_PATH"
echo "Binary verified:"
ls -la "$BINARY_PATH"

- name: Configure environment URLs
run: |
ENV="${{ needs.fetch-azure-config.outputs.environment }}"
Expand Down
Loading