Implement a function to calculate the optimal CFL number for the PERK2 integrator and apply the necessary related updates#2083
Conversation
…lter the existing example
…alculated from dt_opt +fmt
Co-authored-by: Daniel Doehring <doehringd2@gmail.com>
Co-authored-by: Daniel Doehring <doehringd2@gmail.com>
…arisa-r/Trixi.jl into updated_cfl_number_calculation
Review checklistThis checklist is meant to assist creators of PRs (to let them know what reviewers will typically look for) and reviewers (to guide them in a structured review process). Items do not need to be checked explicitly for a PR to be eligible for merging. Purpose and scope
Code quality
Documentation
Testing
Performance
Verification
Created with ❤️ by the Trixi.jl community. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2083 +/- ##
==========================================
+ Coverage 96.32% 96.34% +0.02%
==========================================
Files 470 470
Lines 37492 37501 +9
==========================================
+ Hits 36114 36129 +15
+ Misses 1378 1372 -6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Re-opens #2077. |
|
Please let us know once ready for review 🙂 |
Feel free to drop any comment, this is good to go (was already good to go 😅😬) from my side. |
|
This is a breaking change, @sloede. Do you want to handle the breaking release right now? |
This PR introduces a new function to compute the optimal CFL number based on the optimal time step for the PairedExplicitRK2 (PERK2) integrator.
dt_opt,which is a breaking change Release v0.9 #1997.calculate_cflfunction with the PERK2 integrator.Please let me know if there are any suggestions or improvements!
Original PR: #2077