Skip to content

TypeScript migration#4989

Merged
chasestarr merged 8 commits intouber:masterfrom
zxbodya:ts
Jul 14, 2022
Merged

TypeScript migration#4989
chasestarr merged 8 commits intouber:masterfrom
zxbodya:ts

Conversation

@zxbodya
Copy link
Contributor

@zxbodya zxbodya commented Jun 15, 2022

Convert BaseWeb to TypeScript.

Description

this PR:
  • rename type names trying to match names in existing d.ts files
previous PRs:
  • add .js.flow type definitions from flow sources
  • update styletron dependency
  • update babel and build configuration to support TypeScript
  • convert everything using https://github.com/zxbodya/flowts
  • fix type errors found
todo before publishing next version:
  • to review changes in the type definitions, add aliases for renamed types to minimize amount of type errors
  • update styletron to stable version (to be released)

Scope

Minor: New Feature

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jun 15, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 12b393c:

Sandbox Source
Basic usage Configuration

@chasestarr chasestarr merged commit 58c6a32 into uber:master Jul 14, 2022
@chasestarr chasestarr deleted the ts branch July 14, 2022 19:51
andriuss pushed a commit to andriuss/baseweb that referenced this pull request Aug 2, 2022
* fix(build): update config to publish generated dts files

* fix: run renames script

* fix: issues not covered by rename script

* fix: documentation fixes

* fix: publish config

* chore: update peer dependencies, update readme

* fix(lint): run "eslint --fix" fixing formatting after type renames

* fix: remove not needed alias

Co-authored-by: Chase Starr <chasestarr@gmail.com>

Co-authored-by: Chase Starr <chasestarr@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants