fix(typescript): fix type errors in converted code#5009
Merged
chasestarr merged 37 commits intouber:masterfrom Jul 13, 2022
Merged
fix(typescript): fix type errors in converted code#5009chasestarr merged 37 commits intouber:masterfrom
chasestarr merged 37 commits intouber:masterfrom
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 2c92609:
|
zxbodya
force-pushed
the
type-fixes
branch
2 times, most recently
from
bdafcfa to
8ec845b
Compare
zxbodya
force-pushed
the
type-fixes
branch
2 times, most recently
from
f029fea to
eda0591
Compare
this is needed to avoid possible, error: "error TS2590: Expression produces a union type that is too complex to represent." when using "styled" on typography components
chasestarr
approved these changes
Jul 11, 2022
chasestarr
reviewed
Jul 12, 2022
Contributor
|
Visual changes were detected on this branch. Please review the following PR containing updated snapshots: zxbodya#4 |
Contributor
|
Visual changes have been resolved. zxbodya#4 has been closed. If future commits on |
andriuss
pushed a commit
to andriuss/baseweb
that referenced
this pull request
Aug 2, 2022
* chore(typescript): enable type checks * fix(codegen): update icon generation script * fix(codegen): src/timezonepicker/update-tzdata.js * chore(ts): disable ts checks for documentation site * fix(typescript): manual fixes * fix(typescript): override resize-observer-polyfill type definition * fix(typescript): expose more component props * fix(typescript): simplify types this is needed to avoid possible, error: "error TS2590: Expression produces a union type that is too complex to represent." when using "styled" on typography components * remove /index in imports * fix: locale imports * fix: avoid importing internals * fix(typescript): fix types for banner component * fix(typescript): fix types for badge component * fix: remove file extensions(incorrect) in extract type imports * fix: smaller generated types improve type * fix: use updated StyletronComponent * fix: component overrides for Block and related components * fix: component overrides for Button component * fix: icon types * fix(ts): fixing type errors in tests * chore(ts): enable type check for tests * fix(ts): use react 17 type definitions * fix(ts): fixing type errors in tests * fix(ts): fixing type errors in tests * fix: fix import paths in the tests * fix(wip): types alignment * fix: $as in button component * fix(typescript): remove useless typecasts * fix(typescript): improve types, more fixes * fix(types): fix tabIndex to be a number * fix(types): improve types for withStyles function * fix(types): incorrect usage of React.MouseEvent instead of MouseEvent * fix(types): review feedback, updating/fixing todo comments * chore(comments): mark todos added as part of migration * chore(types): remove flow lint comments * chore(types): remove FlowFixMe comments * fix(types): improve AnchorPropsT
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
part of #4989, depends on #5008
Description
Updating converted code fixing type errors in it.
This is to contain most of the actual changes for the migration to review.
Scope