fix(styletron): correct StyletronComponent signature#5012
fix(styletron): correct StyletronComponent signature#5012simPod wants to merge 1 commit intouber:masterfrom
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 945ed20:
|
8db52fb to
945ed20
Compare
|
that is intended change to have two type arguments in in |
|
@zxbodya upgrading from 11.1.2 to 11.2.0 fails for TS users, since
I'm using latest 5.0.3 v of How to upgrade to baseui 11.2 then? It's using wrong types it seems. |
|
baseui 11.2.0, is relying on types published in:
( |
|
Shouldn't have been the versions of styletron peer dependencies be raised to 6.1 and 3.1? Cuz it's effectively broken for TS users now. Though I understand I should update those dependencies before upgrading to 11.2. Hope other users find this too. |
Description
#5006 broke TS since type declaration has changed
TS2314: Generic type 'StyletronComponent' requires 1 type argument(s).I hope this gets merged so such issues won't happen. Flow was great but it's TS era now (no offense)
Scope
Patch: Bug Fix