feat(layer): implement keyboard event handlers#5080
Merged
chasestarr merged 6 commits intouber:masterfrom Aug 10, 2022
Deliaz:master
Merged
feat(layer): implement keyboard event handlers#5080chasestarr merged 6 commits intouber:masterfrom Deliaz:master
chasestarr merged 6 commits intouber:masterfrom
Deliaz:master
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 29032eb:
|
Contributor
|
Visual changes were detected on this branch. Please review the following PR containing updated snapshots: https://github.com/Deliaz/baseweb/pull/1 |
Contributor
|
Visual changes were detected on this branch. Please review the following PR containing updated snapshots: https://github.com/Deliaz/baseweb/pull/1 |
test(vrt): update visual snapshots for Deliaz:master [skip ci]
chasestarr
approved these changes
Aug 10, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR extends
Layerwith keyboard event handlers as described in https://github.com/uber/baseweb/issues/5021The change shouldn't break anything, however, I think with this new API, the
onEscapemight become deprecated in future versions.Also added ladle example and updated docs.
Scope
Minor: New Feature