Setup: lint, flow, storybook. Proposed Package structure.#1
Merged
DianaSuvorova merged 7 commits intomasterfrom Mar 12, 2018
Merged
Setup: lint, flow, storybook. Proposed Package structure.#1DianaSuvorova merged 7 commits intomasterfrom
DianaSuvorova merged 7 commits intomasterfrom
Conversation
nadiia
reviewed
Mar 9, 2018
.eslintrc.js
Outdated
| "flowtype" | ||
| ], | ||
| "extends": [ | ||
| "airbnb", |
Contributor
There was a problem hiding this comment.
we probably should use eslint-config-uber-universal-stage-3 instead
package.json
Outdated
| "name": "baseui", | ||
| "version": "0.0.1", | ||
| "description": "React implementation of uber design components platform.", | ||
| "main": "src/index.js", |
Contributor
There was a problem hiding this comment.
I think we'll have to transpile, so it'll be dist/index.js
Contributor
|
let's do lower case folders names |
schnerd
reviewed
Mar 9, 2018
package.json
Outdated
| "base-ui" | ||
| ], | ||
| "author": "", | ||
| "license": "ISC", |
Contributor
There was a problem hiding this comment.
MIT + add LICENSE file? (can probably copy from fusion)
Contributor
|
lgtm! excited to try out storybook. we should probably add prettier sooner than later too. |
Collaborator
Author
Contributor
|
I think there is a react plugin we normally use, so we can get rid of airbnb config and use that one instead, but it's a minor thing that we can change any time later. Looks great, let's merge! |
nadiia
approved these changes
Mar 12, 2018
UberOpenSourceBot
pushed a commit
that referenced
this pull request
Nov 7, 2019
test(vrt): update visual snapshots for leyan/flex-grid [skip ci]
UberOpenSourceBot
pushed a commit
that referenced
this pull request
Jan 8, 2020
test(vrt): update visual snapshots for feat/card-img-props [skip ci]
UberOpenSourceBot
pushed a commit
that referenced
this pull request
Feb 4, 2020
test(vrt): update visual snapshots for table-grid-sort [skip ci]
UberOpenSourceBot
pushed a commit
that referenced
this pull request
Mar 2, 2020
UberOpenSourceBot
pushed a commit
that referenced
this pull request
Mar 30, 2020
test(vrt): update visual snapshots for YashGadle:master [skip ci]
UberOpenSourceBot
pushed a commit
that referenced
this pull request
Jul 16, 2020
…ticonsSize test(vrt): update visual snapshots for TanyaChauhan9:flexibleEmoticonsSize [skip ci]
UberOpenSourceBot
pushed a commit
that referenced
this pull request
Dec 16, 2020
test(vrt): update visual snapshots for Deliaz:progress-bar-rounded [skip ci]
UberOpenSourceBot
pushed a commit
that referenced
this pull request
Mar 23, 2021
Adds vrt test for reposition of popover
UberOpenSourceBot
pushed a commit
that referenced
this pull request
Jun 1, 2021
test(vrt): update visual snapshots for gevgeny:shadow-dom-support [skip ci]
Deploying with
|
| Latest commit: |
d842c01
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://1a42eddb.baseweb.pages.dev |
| Branch Preview URL: | https://main.baseweb.pages.dev |
Closed
chasestarr
pushed a commit
that referenced
this pull request
May 24, 2022
* feat(payment-card): added uatp support * feat(payment-card): added uatp support * test(vrt): update visual snapshots for 539d81f [skip ci] (#1) Co-authored-by: UberOpenSourceBot <UberOpenSourceBot@users.noreply.github.com> Co-authored-by: UberOpenSourceBot <33560951+UberOpenSourceBot@users.noreply.github.com> Co-authored-by: UberOpenSourceBot <UberOpenSourceBot@users.noreply.github.com>
UberOpenSourceBot
pushed a commit
that referenced
this pull request
Jul 6, 2022
test(vrt): update visual snapshots for fsilvaco:fix-prop-divider [skip ci]
UberOpenSourceBot
pushed a commit
that referenced
this pull request
Oct 3, 2022
test(vrt): update visual snapshots for mia-le:ml_datatable-submit [skip ci]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is a lot going on here. Please provide feedback.
To try it out
yarn run storybookI added storybook as a dev/testing set up. It is also can be used for demo/docs purposes I was not focusing on the latter.
In this PR:
Didn't add but planning for future PR: