Skip to content

fix(input): add step property to ts defintions#3427

Closed
hsnyildiz wants to merge 1 commit intouber:masterfrom
hsnyildiz:master
Closed

fix(input): add step property to ts defintions#3427
hsnyildiz wants to merge 1 commit intouber:masterfrom
hsnyildiz:master

Conversation

@hsnyildiz
Copy link

I added step support for Input

Fixes #1

Description

I try to use the Input component with type number and step property but I got the typescript error for props. I added optional props.

Scope

Patch: Bug Fix

I added step support for Input
@vercel
Copy link

vercel bot commented Jun 18, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click on the icon next to each commit.

@CLAassistant
Copy link

CLAassistant commented Jun 18, 2020

CLA assistant check
All committers have signed the CLA.

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 3308120:

Sandbox Source
bold-lamport-p366x Configuration

@gergelyke gergelyke changed the title Update Input index.ts for step support fix(input): add step property to ts defintions Jun 18, 2020
@gergelyke
Copy link
Contributor

thank you @hsnyildiz! I wonder, is it something we should add to the Flow types too?

@nadiia
Copy link
Contributor

nadiia commented Jun 18, 2020

How do you pass the step property? I think unless you pass it through the Input overrides it won't be applied to the underlying element. Currently, we don't support the step prop in the Inputs top level API.

@nadiia
Copy link
Contributor

nadiia commented Jun 30, 2020

Closing this one based on the last comment above ^

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants