fix(input): add step definition to number input#3630
Merged
sandgraham merged 3 commits intouber:masterfrom Aug 26, 2020
Merged
Conversation
ProjectBarks
requested review from
chasestarr,
gergelyke,
nadiia,
sandgraham and
tajo
as code owners
|
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit ed5ceb7:
|
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/uber-ui-platform/baseweb/dvdbmannl |
chasestarr
approved these changes
Aug 14, 2020
Collaborator
chasestarr
left a comment
chasestarr
left a comment
There was a problem hiding this comment.
Thank you @ProjectBarks
Contributor
|
@ProjectBarks would you mind adding this to the TS type definitions too? |
ProjectBarks
changed the title
Contributor
Author
|
Contributor
Author
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added step support for Input
Fixes #1
Description
I try to use the Input component with type number and step property but I got the flow error for props. I added optional props. Follow up to, #3427
Scope
Patch: Bug Fix