Skip to content

feat(menu): add menu divider#5132

Merged
chasestarr merged 6 commits intouber:masterfrom
Deliaz:master
Aug 25, 2022
Merged

feat(menu): add menu divider#5132
chasestarr merged 6 commits intouber:masterfrom
Deliaz:master

Conversation

@Deliaz
Copy link
Contributor

@Deliaz Deliaz commented Aug 25, 2022

Description

In this PR I am suggesting adding Divider to the Menu component.
It is made to separate visually menu items.

In order to be displayed just need to add {divied: true} to menu items structure

const ITEMS = [
  {label: 'Menu option A'},
  {label: 'Menu option B'},
  {divider: true},
  {label: 'Menu option X'},
  ...
]

Screen Shot 2022-08-25 at 13 30 50

@codesandbox-ci
Copy link

codesandbox-ci bot commented Aug 25, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit af5d8d5:

Sandbox Source
Basic usage Configuration

@UberOpenSourceBot
Copy link
Contributor

Visual changes were detected on this branch. Please review the following PR containing updated snapshots: https://github.com/Deliaz/baseweb/pull/1

Deliaz and others added 2 commits August 25, 2022 23:43
test(vrt): update visual snapshots for Deliaz:master [skip ci]
@chasestarr chasestarr merged commit 6cb8def into uber:master Aug 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants