feat: status color classes for notification#10989
Merged
Conversation
jouni
force-pushed
the
feat/notification-status-colors
branch
from
8146122 to
bdd850d
Compare
jouni
force-pushed
the
feat/notification-status-colors
branch
from
bdd850d to
3c03ae5
Compare
This was referenced Jan 27, 2026
|
vursen
approved these changes
Feb 2, 2026
Contributor
There was a problem hiding this comment.
I struggled to understand the logic behind the renamings at first, but then it came together. One important insight is that this change aligns notification variants with button variants in Lumo. The "error" button isn't "primary" by default in Lumo while the "error" notification was, which was inconsistent. LGTM.
Collaborator
|
This ticket/PR has been released with Vaadin 25.1.0-alpha5. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #10605
Add class names that can be applied to notifications with both Lumo and Aura:
.v-info.v-success.v-warning.v-errorWith Lumo, an additional
.v-primaryclass name can be added used together with the status color classes, to get the same style as the existingthemeattribute variants. For example,class="v-success v-primary"produces the same result astheme="success", andclass="v-primary"equalstheme="contrast". The class names are intended to replace the theme attribute variants.With Aura, the status color classes are aliases for the existing
.aura-accent-blue|green|yellow|redclass names.