You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Fine tune the accent surface color computation. Align it better with the regular (neutral) surface color. Fix the support for --aura-surface-opacity.
Before & after (light):
Before & after (dark):
Accent surface opacity
The main fix is that the accent surface color now responds to the --aura-surface-opacity property as expected. Before, the accent surface color was always slightly semi-transparent, even with --aura-surface-opacity: 1. This becomes an issue after #10989 is merged, when notification overlays start to use the accent surface color.
This is not applied in Safari 17 (limitation/bug in relative color syntax), and you can see the accent surface colors still being very slightly semi-transparent, especially the lower levels (surface opacity is 1):
We should probably document this limitation/issue.
Component theme tweaks
A few component surface levels and opacities are adjusted at the same time, to align them better together while keeping their appearance close to what they were before.
Button, before & after:
Tabs, before & after:
For the selected tab, I wanted to make the surface level higher, so it’s closer to white in light mode, making it less "dirty" against the background.
Hi @jouni and @web-padawan, when i performed cherry-pick to this commit to 25.0, i have encountered the following issue. Can you take a look and pick it manually?
Error Message:
Error: Command failed: git cherry-pick cdb86d7
error: could not apply cdb86d7... refactor: update aura accent surface color computation (#11038)
hint: After resolving the conflicts, mark them with
hint: "git add/rm ", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fine tune the accent surface color computation. Align it better with the regular (neutral) surface color. Fix the support for
--aura-surface-opacity.Before & after (light):
Before & after (dark):
Accent surface opacity
The main fix is that the accent surface color now responds to the
--aura-surface-opacityproperty as expected. Before, the accent surface color was always slightly semi-transparent, even with--aura-surface-opacity: 1. This becomes an issue after #10989 is merged, when notification overlays start to use the accent surface color.This is not applied in Safari 17 (limitation/bug in relative color syntax), and you can see the accent surface colors still being very slightly semi-transparent, especially the lower levels (surface opacity is 1):

We should probably document this limitation/issue.
Component theme tweaks
A few component surface levels and opacities are adjusted at the same time, to align them better together while keeping their appearance close to what they were before.
Button, before & after:
Tabs, before & after:
For the selected tab, I wanted to make the surface level higher, so it’s closer to white in light mode, making it less "dirty" against the background.


Side Nav, before & after: