Skip to content

refactor: update aura accent surface color computation#11038

Merged
web-padawan merged 4 commits into
mainfrom
fix/accent-surface-color
Jan 30, 2026
Merged

refactor: update aura accent surface color computation#11038
web-padawan merged 4 commits into
mainfrom
fix/accent-surface-color

Conversation

@jouni
Copy link
Copy Markdown
Member

@jouni jouni commented Jan 30, 2026

Fine tune the accent surface color computation. Align it better with the regular (neutral) surface color. Fix the support for --aura-surface-opacity.

Before & after (light):

Screenshot 2026-01-30 at 11 06 12 Screenshot 2026-01-30 at 11 06 58

Before & after (dark):

Screenshot 2026-01-30 at 11 08 14 Screenshot 2026-01-30 at 11 13 33

Accent surface opacity

The main fix is that the accent surface color now responds to the --aura-surface-opacity property as expected. Before, the accent surface color was always slightly semi-transparent, even with --aura-surface-opacity: 1. This becomes an issue after #10989 is merged, when notification overlays start to use the accent surface color.

This is not applied in Safari 17 (limitation/bug in relative color syntax), and you can see the accent surface colors still being very slightly semi-transparent, especially the lower levels (surface opacity is 1):
Screenshot 2026-01-30 at 11 15 57

We should probably document this limitation/issue.

Component theme tweaks

A few component surface levels and opacities are adjusted at the same time, to align them better together while keeping their appearance close to what they were before.

Button, before & after:

Screenshot 2026-01-30 at 11 22 04 Screenshot 2026-01-30 at 11 22 28 Screenshot 2026-01-30 at 11 23 07 Screenshot 2026-01-30 at 11 23 16

Tabs, before & after:

For the selected tab, I wanted to make the surface level higher, so it’s closer to white in light mode, making it less "dirty" against the background.
Screenshot 2026-01-30 at 11 24 39
Screenshot 2026-01-30 at 11 25 21

Screenshot 2026-01-30 at 11 25 52 Screenshot 2026-01-30 at 11 26 03

Side Nav, before & after:

Screenshot 2026-01-30 at 11 25 05 Screenshot 2026-01-30 at 11 25 33 Screenshot 2026-01-30 at 11 26 15 Screenshot 2026-01-30 at 11 26 23

@web-padawan web-padawan force-pushed the fix/accent-surface-color branch from b849ca9 to 64329b0 Compare January 30, 2026 12:46
@web-padawan web-padawan changed the title fix: aura accent surface color refactor: update aura accent surface color computation Jan 30, 2026
Copy link
Copy Markdown
Member

@web-padawan web-padawan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Updated visual tests screenshots for button, drawer-toggle and upload-button.

@sonarqubecloud
Copy link
Copy Markdown

@web-padawan web-padawan merged commit cdb86d7 into main Jan 30, 2026
10 checks passed
@web-padawan web-padawan deleted the fix/accent-surface-color branch January 30, 2026 12:58
@vaadin-bot
Copy link
Copy Markdown
Collaborator

Hi @jouni and @web-padawan, when i performed cherry-pick to this commit to 25.0, i have encountered the following issue. Can you take a look and pick it manually?
Error Message:
Error: Command failed: git cherry-pick cdb86d7
error: could not apply cdb86d7... refactor: update aura accent surface color computation (#11038)
hint: After resolving the conflicts, mark them with
hint: "git add/rm ", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants