refactor: don't adjust container padding based on border-radius#11365
Merged
web-padawan merged 1 commit intomainfrom Mar 18, 2026
Merged
refactor: don't adjust container padding based on border-radius#11365web-padawan merged 1 commit intomainfrom
web-padawan merged 1 commit intomainfrom
Conversation
|
web-padawan
approved these changes
Mar 18, 2026
vaadin-bot
pushed a commit
that referenced
this pull request
Mar 18, 2026
web-padawan
pushed a commit
that referenced
this pull request
Mar 18, 2026
…) (#11366) Co-authored-by: Jouni Koivuviita <jouni@vaadin.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adjusting the container (input field, button, side-nav, tabs, etc) inline-padding based on the border-radius can be unexpected, and doesn't provide much added benefit visually.
The default padding stays the same. This can have a minor visual change on apps that use a large
--aura-base-radiusvalue.