Skip to content

refactor: don't adjust container padding based on border-radius #11365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
web-padawan merged 1 commit into from
Mar 18, 2026
Merged

refactor: don't adjust container padding based on border-radius #11365

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 6 additions & 8 deletions packages/aura/src/components/button.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,25 +39,23 @@ Increase padding, but only for buttons that don't have an icon in the default sl
Buttons that place an icon in the default slot are assumed to be icon-only buttons.
*/
/* prettier-ignore */
:is(vaadin-button, vaadin-upload-button, vaadin-menu-bar-button, vaadin-drawer-toggle, vaadin-crud-edit):not(:has(> :is(vaadin-icon, svg, i[class*='fa-'], vaadin-avatar):not([slot]))) {
--vaadin-button-padding: round(var(--vaadin-padding-s) / 1.4, 1px)
max(var(--vaadin-padding-m), round(var(--vaadin-radius-m) / 1.5, 1px));
:is(vaadin-button, vaadin-upload-button, vaadin-menu-bar-button, vaadin-crud-edit):not(:has(> :is(vaadin-icon, svg, i[class*='fa-'], vaadin-avatar):not([slot]))) {
--vaadin-button-padding: var(--vaadin-padding-block-container)
var(--vaadin-padding-m);
}

/* Decrease padding when an icon is placed in the prefix or suffix slot */
:is(vaadin-button, vaadin-upload-button, vaadin-menu-bar-button):has(
> [slot='prefix']:is(vaadin-icon, svg, i[class*='fa-'], vaadin-avatar)
),
vaadin-drawer-toggle:empty {
padding-inline-start: max(var(--vaadin-padding-s), round(var(--vaadin-radius-m) / 1.75, 1px));
) {
padding-inline-start: var(--vaadin-padding-s);
}

:is(vaadin-button, vaadin-upload-button, vaadin-menu-bar-button):has(
> [slot='suffix']:is(vaadin-icon, svg, i[class*='fa-'], vaadin-avatar)
),
vaadin-drawer-toggle:empty,
vaadin-menu-bar-button[aria-haspopup='true']:not([slot='overflow']) {
padding-inline-end: max(var(--vaadin-padding-s), round(var(--vaadin-radius-m) / 1.75, 1px));
padding-inline-end: var(--vaadin-padding-s);
}

:is(vaadin-button, vaadin-upload-button, vaadin-menu-bar-button, vaadin-drawer-toggle, vaadin-crud-edit):where(
Expand Down
2 changes: 1 addition & 1 deletion packages/aura/src/size.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
--vaadin-gap-xl: round(var(--aura-base-size) * 1.5 * 1px, 1px);

--vaadin-padding-block-container: round(var(--vaadin-padding-s) / 1.4, 1px);
--vaadin-padding-inline-container: max(var(--vaadin-padding-s), round(var(--vaadin-radius-m) / 2, 1px));
--vaadin-padding-inline-container: var(--vaadin-padding-s);

--vaadin-padding-xs: round(var(--aura-base-size) * 0.25 * 1px, 1px);
--vaadin-padding-s: round(var(--aura-base-size) * 0.5 * 1px, 1px);
Expand Down
Loading