fix: remove flex: 1 from scroller base styles to respect explicit height#11373
Merged
DiegoCardoso merged 2 commits intomainfrom Mar 19, 2026
Merged
fix: remove flex: 1 from scroller base styles to respect explicit height#11373DiegoCardoso merged 2 commits intomainfrom
DiegoCardoso merged 2 commits intomainfrom
Conversation
…ght (#11372) Since v25.0, setting an explicit height on vaadin-scroller inside a flex container had no effect because flex: 1 on :host forced the scroller to grow and fill available space. Parent components (app-layout, tabsheet) already set their own flex rules on the scroller when needed, so this default was unnecessary and overly opinionated. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
sissbruecker
approved these changes
Mar 19, 2026
.claude/worktrees/agent-ac53ddde
Outdated
|
vaadin-bot
pushed a commit
that referenced
this pull request
Mar 19, 2026
…ght (#11373) Since v25.0, setting an explicit height on vaadin-scroller inside a flex container had no effect because flex: 1 on :host forced the scroller to grow and fill available space. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
vaadin-bot
pushed a commit
that referenced
this pull request
Mar 19, 2026
…ght (#11373) Since v25.0, setting an explicit height on vaadin-scroller inside a flex container had no effect because flex: 1 on :host forced the scroller to grow and fill available space. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
sissbruecker
pushed a commit
that referenced
this pull request
Mar 19, 2026
…ght (#11373) (#11377) Since v25.0, setting an explicit height on vaadin-scroller inside a flex container had no effect because flex: 1 on :host forced the scroller to grow and fill available space. Co-authored-by: Diego Cardoso <diego@vaadin.com> Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
sissbruecker
pushed a commit
that referenced
this pull request
Mar 19, 2026
…ght (#11373) (#11378) Since v25.0, setting an explicit height on vaadin-scroller inside a flex container had no effect because flex: 1 on :host forced the scroller to grow and fill available space. Co-authored-by: Diego Cardoso <diego@vaadin.com> Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Since v25.0, setting an explicit height on
vaadin-scrollerinside a flex container had no effect because flex: 1 on:hostforced the scroller to grow and fill available space.Fixes #11372
Type of change